Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make option-like-enum.rs UB-free and portable #129672

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Aug 27, 2024

Fixes #129662

(or, at least the parts of it that aren't #128973)

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2024

📌 Commit 1a2ec26 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128495 (core: use `compare_bytes` for more slice element types)
 - rust-lang#128641 (refactor: standardize duplicate processes in parser)
 - rust-lang#129207 (Lint that warns when an elided lifetime ends up being a named lifetime)
 - rust-lang#129493 (Create opaque definitions in resolver.)
 - rust-lang#129619 (Update stacker to 0.1.17)
 - rust-lang#129672 (Make option-like-enum.rs UB-free and portable)
 - rust-lang#129780 (add crashtests for several old unfixed ICEs)
 - rust-lang#129832 (Remove stray dot in `std::char::from_u32_unchecked` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d24336b into rust-lang:master Sep 1, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Sep 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2024
Rollup merge of rust-lang#129672 - saethlin:enum-debuginfo-tests, r=Mark-Simulacrum

Make option-like-enum.rs UB-free and portable

Fixes rust-lang#129662

(or, at least the parts of it that aren't rust-lang#128973)
@saethlin saethlin deleted the enum-debuginfo-tests branch September 1, 2024 08:12
@cuviper cuviper modified the milestones: 1.82.0, 1.83.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected nulls in debuginfo tests on windows-gnu
5 participants