Revert #129187 and #129302

[jieyouxu]

The two PRs naively switched to std::fs::remove_dir_all, but failed to gracefully handle the failure case where the top-level directory entry does not exist, causing #129187 (comment) ./x clean to fail locally when tmp does not exist.

I plan to reland the two PRs with fixed top-level dir entry handling and more testing, but let's quickly revert to unblock people.

Reverts #129187.
Reverts #129302.

r? bootstrap

[jieyouxu]

@bors p=10 rollup=never (this blocks users of ./x clean)

[compiler-errors]

SAD

@bors r+

[bors]

📌 Commit 3957f39 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3957f39 with merge 1b6f4c7...

[rust-log-analyzer]

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.488
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Thu, Aug 22, 2024  8:02:09 PM
  network time: Thu, 22 Aug 2024 20:02:10 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

[bors]

💔 Test failed - checks-actions

[jieyouxu]

@bors retry (msvc ci spurious failure)

[bors]

⌛ Testing commit 3957f39 with merge b5723af...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b5723af to master...

[rust-timer]

Finished benchmarking commit (b5723af): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.3%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-2.1%	[-2.8%, -1.6%]	3
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	-1.3%	[-2.8%, 1.4%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.6s -> 749.494s (-0.15%)
Artifact size: 338.94 MiB -> 338.87 MiB (-0.02%)