Refactor: Mv `OsStr`/`OsStrExt`/`Path` to core, `OsString`/`OsStringExt`/`PathBuf` to alloc #129411

NobodyXu · 2024-08-22T14:51:30Z

rustbot · 2024-08-22T14:51:38Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2024-08-23T11:52:17Z

☔ The latest upstream changes (presumably #129443) made this pull request unmergeable. Please resolve the merge conflicts.

workingjubilee · 2024-08-25T21:15:57Z

Thanks so much for working on this, this is going to make working on backtrace so much more tolerable.

clarfonthey · 2024-08-25T21:19:31Z

library/alloc/src/ffi/mod.rs

@@ -89,3 +89,18 @@ pub use self::c_str::{FromVecWithNulError, IntoStringError, NulError};

 #[unstable(feature = "c_str_module", issue = "112134")]
 pub mod c_str;
+
+#[stable(feature = "rust1", since = "1.0.0")]


Presumably only the re-exports in libstd should have these, and the alloc/core originals should be marked unstable for now.

Thanks, I've marked them as unstable for now.

Someone else interested in it could stablise it.

bors · 2024-09-02T04:27:37Z

☔ The latest upstream changes (presumably #129063) made this pull request unmergeable. Please resolve the merge conflicts.

…xt` to alloc Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

rust-log-analyzer · 2024-09-02T14:27:41Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 2.851 Building wheels for collected packages: reuse
#16 2.852   Building wheel for reuse (pyproject.toml): started
#16 3.092   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.093   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#16 3.093   Stored in directory: /tmp/pip-ephem-wheel-cache-hnbdbu5_/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.096 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.494 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.494 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.6s

bors · 2024-09-04T20:56:44Z

☔ The latest upstream changes (presumably #129962) made this pull request unmergeable. Please resolve the merge conflicts.

NobodyXu · 2024-10-20T10:05:42Z

I'm giving up on this PR as I don't have much time to work on it lately.

And I'm not sure I can resolve the concern raised by the team.

For rust-lang/libs-team#399, I might have to think of a different solution, like marking Arc/Rc of being fundamental

clarfonthey · 2024-10-20T16:01:24Z

I may be able to take up at least fixing up this PR, minus fixing the design issues with the other change. I think that at least lowering the requirements for these in an unstable way is fine.

rustbot assigned Mark-Simulacrum Aug 22, 2024