safe transmute: gracefully bubble-up layout errors #129364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
tests/ui/transmutability/malformed-program-gracefulness/unknown_dst_field.rs
Outdated
Show resolved
Hide resolved
jswrenn
force-pushed
the
transmute-layout-errs
branch
from
dff0f99 to
a0fa0e0
Compare
Changes `.unwrap()`s to `?` to avoid ICEs. Adds ui tests. Fixes rust-lang#129327
jswrenn
force-pushed
the
transmute-layout-errs
branch
from
a0fa0e0 to
e2328eb
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128727 (bump conflicting_repr_hints lint to be shown in dependencies) - rust-lang#129232 (Fix `thread::sleep` Duration-handling for ESP-IDF) - rust-lang#129321 (Change neutral element of <fNN as iter::Sum> to neg_zero) - rust-lang#129353 (llvm-wrapper: adapt for LLVM 20 API changes) - rust-lang#129363 (Force `LC_ALL=C` for all run-make tests) - rust-lang#129364 (safe transmute: gracefully bubble-up layout errors) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2024
Rollup merge of rust-lang#129364 - jswrenn:transmute-layout-errs, r=compiler-errors safe transmute: gracefully bubble-up layout errors Changes `.unwrap()`s to `?` to avoid ICEs. Adds ui tests. Fixes rust-lang#129327 Tracking Issue: rust-lang#99571 r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.unwrap()s to?to avoid ICEs. Adds ui tests.Fixes #129327
Tracking Issue: #99571
r? @compiler-errors