Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc rfc#3662 changes under unstable flags #129337

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Commits on Sep 7, 2024

  1. librustdoc::config: removed Input from Options

    The `librustdoc::config::Options` struct no longer includes
    `rustc_session::config::Input`. This is so that Input can be optional.
    In rfc#3662, the crate input is not required if `--merge=finalize`.
    
    Replacing Input with Option<Input> was decided against. In most places
    that Input is needed, it should be statically known to not be optional
    (means fewer unwraps). We just want to have an Input-free Options in
    librustdoc::main_args, where we can run the write shared procedure.
    EtomicBomb authored and ethan committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    3782251 View commit details
    Browse the repository at this point in the history
  2. rfc#3662 changes under unstable flags

    * All new functionality is under unstable options
    * Adds `--merge=shared|none|finalize` flags
    * Adds `--parts-out-dir=<crate specific directory>` for `--merge=none`
    to write cross-crate info file for a single crate
    * Adds `--include-parts-dir=<previously specified directory>` for
    `--merge=finalize` to write cross-crate info files
    * update tests/run-make/rustdoc-default-output/rmake.rs golden
    EtomicBomb authored and ethan committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    2e1cba6 View commit details
    Browse the repository at this point in the history
  3. add tests for behavior in rfc#3662

    * Adds tests for the behavior from rfc#3662 in `tests/rustdoc/`
    EtomicBomb committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    548b6e1 View commit details
    Browse the repository at this point in the history