Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_lang_item more #129061

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Use is_lang_item more #129061

merged 1 commit into from
Aug 14, 2024

Conversation

compiler-errors
Copy link
Member

Few places that I missed since introducing TyCtxt::is_lang_item.

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2024
@Urgau
Copy link
Member

Urgau commented Aug 13, 2024

r=me when CI is successful
r? Urgau

@rustbot rustbot assigned Urgau and unassigned pnkfelix Aug 13, 2024
@Urgau
Copy link
Member

Urgau commented Aug 13, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 13, 2024

📌 Commit bac1968 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2024
@bors
Auto merge of rust-lang#129076 - matthiaskrgr:rollup-rg8mi2x, r=matth…
9859bf2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake)
 - rust-lang#128759 (alloc: add ToString specialization for `&&str`)
 - rust-lang#128873 (Add windows-targets crate to std's sysroot)
 - rust-lang#129001 (chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…)
 - rust-lang#129061 (Use `is_lang_item` more)
 - rust-lang#129062 (Remove a no-longer-true assert)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cd6852b into rust-lang:master Aug 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 14, 2024
@rust-timer
Unrolled build for rust-lang#129061
bf5734f 
Rollup merge of rust-lang#129061 - compiler-errors:lang-item, r=Urgau

Use `is_lang_item` more

Few places that I missed since introducing `TyCtxt::is_lang_item`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @Urgau @bors @pnkfelix