-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect incompatible CI rustc options more precisely #129052
detect incompatible CI rustc options more precisely #129052
Commits on Aug 13, 2024
-
copy
builder-config
file into ci-rustc sysrootSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for aba675f - Browse repository at this point
Copy the full SHA aba675fView commit details -
separate inner function (
get_toml
) ofConfig::parse
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for b2f1fc1 - Browse repository at this point
Copy the full SHA b2f1fc1View commit details -
detect incompatible CI rustc options more precisely
Previously, the logic here was simply checking whether the option was set in `config.toml`. This approach was not manageable in our CI runners as we set so many options in config.toml. In reality, those values are not incompatible since they are usually the same value used to generate the CI rustc. Now, the new logic compares the configuration values with the values used to generate the CI rustc, so we get more precise results and make the process more manageable. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 0518e8c - Browse repository at this point
Copy the full SHA 0518e8cView commit details
Commits on Aug 14, 2024
-
print values of incompatible options
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for b76f6a3 - Browse repository at this point
Copy the full SHA b76f6a3View commit details -
do not check incompatibility if
config.toml
isn't presentSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 43320d5 - Browse repository at this point
Copy the full SHA 43320d5View commit details -
create
const BUILDER_CONFIG_FILENAME
for builder-config fileSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 4d21c73 - Browse repository at this point
Copy the full SHA 4d21c73View commit details -
fix the incorrect
unpack
ing logicSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 4d13470 - Browse repository at this point
Copy the full SHA 4d13470View commit details -
improve
config::check_incompatible_options_for_ci_rustc
logsSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 151e8cd - Browse repository at this point
Copy the full SHA 151e8cdView commit details -
leave a FIXME note for
--set
flags coverageSigned-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 0935c86 - Browse repository at this point
Copy the full SHA 0935c86View commit details -
disable download-rustc if CI rustc has unsupported options
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 469d593 - Browse repository at this point
Copy the full SHA 469d593View commit details