Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect incompatible CI rustc options more precisely #129052

Merged
merged 10 commits into from
Aug 16, 2024

Commits on Aug 13, 2024

  1. copy builder-config file into ci-rustc sysroot

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    aba675f View commit details
    Browse the repository at this point in the history
  2. separate inner function (get_toml) of Config::parse

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b2f1fc1 View commit details
    Browse the repository at this point in the history
  3. detect incompatible CI rustc options more precisely

    Previously, the logic here was simply checking whether the option was set in `config.toml`.
    This approach was not manageable in our CI runners as we set so many options in config.toml.
    In reality, those values are not incompatible since they are usually the same value used to generate
    the CI rustc. Now, the new logic compares the configuration values with the values used to generate
    the CI rustc, so we get more precise results and make the process more manageable.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0518e8c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. print values of incompatible options

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b76f6a3 View commit details
    Browse the repository at this point in the history
  2. do not check incompatibility if config.toml isn't present

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    43320d5 View commit details
    Browse the repository at this point in the history
  3. create const BUILDER_CONFIG_FILENAME for builder-config file

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4d21c73 View commit details
    Browse the repository at this point in the history
  4. fix the incorrect unpacking logic

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4d13470 View commit details
    Browse the repository at this point in the history
  5. improve config::check_incompatible_options_for_ci_rustc logs

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    151e8cd View commit details
    Browse the repository at this point in the history
  6. leave a FIXME note for --set flags coverage

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0935c86 View commit details
    Browse the repository at this point in the history
  7. disable download-rustc if CI rustc has unsupported options

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    469d593 View commit details
    Browse the repository at this point in the history