-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up dump-ice-to-disk
and make assertion failures dump ICE messages
#128916
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Running a couple of try jobs for sanity check. @bors try |
In the meantime, @rustbot author |
Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages A bit of clean up to the `dump-ice-to-disk` test. - Fixes/updates the top-level comment. - Add a FIXME pointing to rust-lang#128911 for flakiness. - Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory. - Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment. - Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911). Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top. try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-msvc try-job: i686-mingw try-job: test-various
☀️ Try build successful - checks-actions |
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me when that dependency lands
Needs rebase then r=me @rustbot author |
30b7e0b
to
960e7b5
Compare
Based on https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/getting.20.60Box.3Cdyn.20Any.3E.60.20as.20ICE.20message I am suspecting that this test is in fact not flakey and is correctly doing its job, and that our ICE dumps actually regressed. We'll see if the verbose dumps reveal anything in completely unrelated PRs again. |
In any case, we can merge the verbose dumping first to see if it fails somewhere else completely unrelated and how it failed. |
... I feel like PR CI is doing something weird here, it's been 2 hours and usually PR CI doesn't take that long. In any case, we'll see this in full CI if this fails. @bors r=@compiler-errors rollup=iffy (this test is known to be flakey on |
Oh wait can't do that, or else bors might send this straight to master without any testing. |
Please don't be waiting on bors! @bors r- |
bors please wait! @bors r- |
Re-opening since the try job on the draft PR #128958 is done. Maybe it won't be so cursed this time. |
@bors r=@compiler-errors rollup=iffy (this test is known to be flakey on |
…iler-errors Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages For the future traveler: **if you did a `git blame` and found this PR that last modified `dump-ice-to-disk` because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on `i686-mingw`.** A bit of clean up to the `dump-ice-to-disk` test. - Fixes/updates the top-level comment. - Add a FIXME pointing to rust-lang#128911 for flakiness. - Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory. - Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment. - Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911). Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top. try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-msvc try-job: i686-mingw try-job: test-various
Going to ignore this test on windows so I can investigate on the side and not block full CI. |
…iler-errors Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages For the future traveler: **if you did a `git blame` and found this PR that last modified `dump-ice-to-disk` because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on `i686-mingw`.** A bit of clean up to the `dump-ice-to-disk` test. - Fixes/updates the top-level comment. - Add a FIXME pointing to rust-lang#128911 for flakiness. - Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory. - Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment. - Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911). Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top. try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-msvc try-job: i686-mingw try-job: test-various
Rollup of 5 pull requests Successful merges: - rust-lang#128643 (Refactor `powerpc64` call ABI handling) - rust-lang#128873 (Add windows-targets crate to std's sysroot) - rust-lang#128916 (Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages) - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago) - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`) r? `@ghost` `@rustbot` modify labels: rollup
☀️ Test successful - checks-actions |
Finished benchmarking commit (5e5ec8a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.3%, secondary -4.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 757.742s -> 758.668s (0.12%) |
For the future traveler: if you did a
git blame
and found this PR that last modifieddump-ice-to-disk
because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently oni686-mingw
.A bit of clean up to the
dump-ice-to-disk
test.tests/run-make/dump-ice-to-disk
is flakey on i686-mingw #128911 for flakiness.rustc-ice*.txt
dumps, run each test instance in a separate temp directory.RUSTC_ICE
unavailable in one of the-Zmetrics-dir
test case to not have interference from environment.tests/run-make/dump-ice-to-disk
is flakey on i686-mingw #128911).Contains a fix by @saethlin in #128909, should wait until that is merged then rebase on top.
try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various