Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up dump-ice-to-disk and make assertion failures dump ICE messages #128916

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Aug 10, 2024

For the future traveler: if you did a git blame and found this PR that last modified dump-ice-to-disk because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on i686-mingw.

A bit of clean up to the dump-ice-to-disk test.

Contains a fix by @saethlin in #128909, should wait until that is merged then rebase on top.

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2024
@jieyouxu
Copy link
Member Author

Running a couple of try jobs for sanity check.

@bors try

@jieyouxu
Copy link
Member Author

In the meantime, @rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2024
Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages

A bit of clean up to the `dump-ice-to-disk` test.

- Fixes/updates the top-level comment.
- Add a FIXME pointing to rust-lang#128911 for flakiness.
- Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory.
- Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment.
- Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911).

Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top.

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
@bors
Copy link
Contributor

bors commented Aug 10, 2024

⌛ Trying commit 30b7e0b with merge ded2b46...

@bors
Copy link
Contributor

bors commented Aug 10, 2024

☀️ Try build successful - checks-actions
Build commit: ded2b46 (ded2b46501204598d0759fbd5e38516f4331e4c6)

@jieyouxu
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when that dependency lands

@compiler-errors
Copy link
Member

Needs rebase then r=me

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2024
@jieyouxu
Copy link
Member Author

Based on https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/getting.20.60Box.3Cdyn.20Any.3E.60.20as.20ICE.20message I am suspecting that this test is in fact not flakey and is correctly doing its job, and that our ICE dumps actually regressed. We'll see if the verbose dumps reveal anything in completely unrelated PRs again.

@jieyouxu
Copy link
Member Author

jieyouxu commented Aug 11, 2024

In any case, we can merge the verbose dumping first to see if it fails somewhere else completely unrelated and how it failed.

@jieyouxu
Copy link
Member Author

jieyouxu commented Aug 11, 2024

... I feel like PR CI is doing something weird here, it's been 2 hours and usually PR CI doesn't take that long. In any case, we'll see this in full CI if this fails.

@bors r=@compiler-errors rollup=iffy (this test is known to be flakey on i686-mingw)

@jieyouxu
Copy link
Member Author

Oh wait can't do that, or else bors might send this straight to master without any testing.
@bors r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2024
@jieyouxu jieyouxu closed this Aug 11, 2024
@jieyouxu jieyouxu reopened this Aug 11, 2024
@jieyouxu
Copy link
Member Author

Please don't be waiting on bors! @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2024
@jieyouxu
Copy link
Member Author

bors please wait! @bors r-

@jieyouxu
Copy link
Member Author

Re-opening since the try job on the draft PR #128958 is done. Maybe it won't be so cursed this time.

@jieyouxu jieyouxu reopened this Aug 11, 2024
@jieyouxu
Copy link
Member Author

@bors r=@compiler-errors rollup=iffy (this test is known to be flakey on i686-mingw)

@bors
Copy link
Contributor

bors commented Aug 11, 2024

📌 Commit 960e7b5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2024
@jieyouxu
Copy link
Member Author

I'm actually going to bump this higher because #122362 failed on dump-ice-to-disk again on i686-mingw.

@bors p=1 (other full CI is failing on this test, and this PR tries to make the failure cause more obvious)

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 11, 2024
…iler-errors

Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages

For the future traveler: **if you did a `git blame` and found this PR that last modified `dump-ice-to-disk` because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on `i686-mingw`.**

A bit of clean up to the `dump-ice-to-disk` test.

- Fixes/updates the top-level comment.
- Add a FIXME pointing to rust-lang#128911 for flakiness.
- Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory.
- Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment.
- Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911).

Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top.

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
@jieyouxu
Copy link
Member Author

Going to ignore this test on windows so I can investigate on the side and not block full CI.

@jieyouxu
Copy link
Member Author

@bors r=@compiler-errors

@bors
Copy link
Contributor

bors commented Aug 11, 2024

📌 Commit 6dc300b has been approved by compiler-errors

It is now in the queue for this repository.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 11, 2024
…iler-errors

Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages

For the future traveler: **if you did a `git blame` and found this PR that last modified `dump-ice-to-disk` because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on `i686-mingw`.**

A bit of clean up to the `dump-ice-to-disk` test.

- Fixes/updates the top-level comment.
- Add a FIXME pointing to rust-lang#128911 for flakiness.
- Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory.
- Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment.
- Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (rust-lang#128911).

Contains a fix by `@saethlin` in rust-lang#128909, should wait until that is merged then rebase on top.

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#128643 (Refactor `powerpc64` call ABI handling)
 - rust-lang#128873 (Add windows-targets crate to std's sysroot)
 - rust-lang#128916 (Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages)
 - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Aug 11, 2024

⌛ Testing commit 6dc300b with merge 5e5ec8a...

@bors
Copy link
Contributor

bors commented Aug 11, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5e5ec8a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2024
@bors bors merged commit 5e5ec8a into rust-lang:master Aug 11, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 11, 2024
@jieyouxu jieyouxu deleted the dump-ice-dump-ice branch August 11, 2024 15:16
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5e5ec8a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary -4.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) 2.3% [2.3%, 2.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.742s -> 758.668s (0.12%)
Artifact size: 339.25 MiB -> 339.27 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants