-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote aarch64-apple-darwin to Tier 1 #128591
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
253c9b0
to
9880437
Compare
The Miri subtree was changed cc @rust-lang/miri This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
@@ -212,7 +212,6 @@ degree documented below): | |||
- All Rust [Tier 1 targets](https://doc.rust-lang.org/rustc/platform-support.html) are supported by | |||
Miri. They are all checked on Miri's CI, and some (at least one per OS) are even checked on every | |||
Rust PR, so the shipped Miri should always work on these targets. | |||
- `aarch64-apple-darwin` is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment here also needs updating now.
The one use of it was guaranteed to be always true.
9880437
to
1b74238
Compare
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/cargo cc @ehuss |
going to close this and reopen because i accidentally stumbled with the rebase. oops. |
This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted.