Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to string formatting if source is not available for lint #128517

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fallback to string formatting if source is not available for lint #128517

merged 1 commit into from
Aug 7, 2024

Conversation

clubby789
Copy link
Contributor

Fixes #128445

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 1, 2024
@clubby789 clubby789 changed the title Fallback to string formatting if source is not available Fallback to string formatting if source is not available for lint Aug 1, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2024

📌 Commit 3cd445a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@bors
Auto merge of rust-lang#128748 - matthiaskrgr:rollup-dzvi5f7, r=matth…
0ddead3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128369 (rustc_lint: make `let-underscore-lock` translatable)
 - rust-lang#128377 (Fix ICE Caused by Incorrectly Delaying E0107)
 - rust-lang#128517 (Fallback to string formatting if source is not available for lint)
 - rust-lang#128685 (Remove the root Cargo.lock from the rust-src component)
 - rust-lang#128693 (rustdoc-search: account for numeric disambiguators on impls)
 - rust-lang#128720 (Pass the right `ParamEnv` to `might_permit_raw_init_strict`)
 - rust-lang#128736 (Fix rustdoc missing handling of remap-path-prefix option)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f9ebb5 into rust-lang:master Aug 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2024
@rust-timer
Unrolled build for rust-lang#128517
4ff8147 
Rollup merge of rust-lang#128517 - clubby789:overflowing-lit-span, r=petrochenkov

Fallback to string formatting if source is not available for lint

Fixes rust-lang#128445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

ICE: Lint: Diagnostic "literal out of range" crashes if the source is not available
4 participants
@clubby789 @rustbot @petrochenkov @bors