Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize offset_of_nested #128284

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Stabilize offset_of_nested #128284

merged 1 commit into from
Jul 30, 2024

Conversation

GKFX
Copy link
Contributor

@GKFX GKFX commented Jul 27, 2024

Tracking issue #120140. Closes #120140.

As the FCP is now nearing its end I have opened a stabilization PR. I have done this separately to the offset_of_enum feature, since that FCP has not started.

@rustbot label F-offset_of_nested T-lang T-libs-api

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added F-offset_of_nested `#![feature(offset_of_nested)]` T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 27, 2024
@GKFX GKFX mentioned this pull request Jul 27, 2024
Closed
3 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

jieyouxu commented Jul 27, 2024 •
edited
Loading

I'll start summoning reviewers from other relevant teams once the FCP finishes. Please flip the status to ready for review as soon as the FCP passes :3

@rustbot blocked (waiting for completion of FCP in #120140)

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2024
@traviscross

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added I-lang-nominated Nominated for discussion during a lang team meeting. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Jul 27, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dtolnay

This comment was marked as resolved.

Sign in to view
@traviscross

This comment was marked as resolved.

Sign in to view
@traviscross

This comment was marked as resolved.

Sign in to view
@rustbot rustbot removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 27, 2024
@jieyouxu
Copy link
Member

@rustbot review (FCP is now complete)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 28, 2024
jieyouxu
jieyouxu approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler and tests/ changes LGTM, r=me for those changes

@jieyouxu
Copy link
Member

Rolling a T-libs-api reviewer for the libs changes
r? libs-api

@rustbot rustbot assigned BurntSushi and unassigned jieyouxu Jul 28, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GKFX GKFX force-pushed the stabilize-offset-of-nested branch from 31aa106 to 23f46e5 Compare July 29, 2024 16:50
dtolnay
dtolnay approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Jul 29, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2024

📌 Commit 23f46e5 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2024
@dtolnay
Copy link
Member

dtolnay commented Jul 29, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2024
@dtolnay
Copy link
Member

dtolnay commented Jul 29, 2024

@bors r=dtolnay,jieyouxu

@bors
Copy link
Contributor

bors commented Jul 29, 2024

📌 Commit 23f46e5 has been approved by dtolnay,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2024
@bors
Auto merge of rust-lang#128360 - matthiaskrgr:rollup-wwy5mkj, r=matth…
368e2fd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126247 (rustdoc: word wrap CamelCase in the item list table and sidebar)
 - rust-lang#128104 (Not lint pub structs without pub constructors intentionally)
 - rust-lang#128153 (Stop using `MoveDataParamEnv` for places that don't need a param-env)
 - rust-lang#128284 (Stabilize offset_of_nested)
 - rust-lang#128342 (simplify the use of `CiEnv`)
 - rust-lang#128355 (triagebot: make sure Nora is called Nora)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a73a025 into rust-lang:master Jul 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Jul 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@rust-timer
Unrolled build for rust-lang#128284
3566948 
Rollup merge of rust-lang#128284 - GKFX:stabilize-offset-of-nested, r=dtolnay,jieyouxu

Stabilize offset_of_nested

Tracking issue rust-lang#120140. Closes rust-lang#120140.

As the FCP is now nearing its end I have opened a stabilization PR. I have done this separately to the offset_of_enum feature, since that FCP has not started.

`@rustbot` label  F-offset_of_nested T-lang T-libs-api
@GKFX GKFX deleted the stabilize-offset-of-nested branch July 30, 2024 06:52
@Urgau Urgau added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 31, 2024
@Mark-Simulacrum Mark-Simulacrum added relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Aug 25, 2024
@rustbot rustbot mentioned this pull request Aug 25, 2024
Open
4 tasks
@nikomatsakis nikomatsakis mentioned this pull request Aug 28, 2024
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@dtolnay dtolnay

Labels
F-offset_of_nested `#![feature(offset_of_nested)]` relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for nested field access in offset_of
10 participants
@GKFX @rustbot @rust-log-analyzer @jieyouxu @traviscross @dtolnay @bors @BurntSushi @Urgau @Mark-Simulacrum