Disable run-make/split-debuginfo test for RISC-V 64 #127967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
jieyouxu
approved these changes
Jul 19, 2024
|
Thanks! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112328 (Feat. adding ext that returns change_time) - rust-lang#126199 (Add `isqrt` to `NonZero<uN>`) - rust-lang#127856 (interpret: add sanity check in dyn upcast to double-check what codegen does) - rust-lang#127934 (Improve error when a compiler/library build fails in `checktools.sh`) - rust-lang#127960 (Cleanup dll/exe filename calculations in `run_make_support`) - rust-lang#127963 (Fix display of logo "border") - rust-lang#127967 (Disable run-make/split-debuginfo test for RISC-V 64) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2024
Rollup merge of rust-lang#127967 - joshua-zivkovic:joshua-zivkovic/disable-split-debuginfo, r=jieyouxu Disable run-make/split-debuginfo test for RISC-V 64 Together with `@Hoverbear,` we've been improving the state of the riscv64gc-unknown-linux-gnu target. This is in relation to rust-lang#125220 where `tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rs` was disabled for RISC-V 64 in that another test, `tests/run-make/split-debuginfo` also needs to be disabled due to llvm/llvm-project#56642 and the changes made in rust-lang#120518. This test appears to be a host test, not a target test, so it isn't seen failing in rust-lang#126641, however, we are in the process of testing host tools for riscv64-gc-unknown-linux-gnu so this test has now been noticed to be a problem.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2024
…-testing, r=<try> Enable `riscv64gc-gnu` testing Together with joshua.zivkovic@codethink.co.uk, we've been starting to explore improving the state of the `riscv64gc-unknown-linux-gnu` target. Additionally, I'm looking to add support for this platform in [Ferrocene](https://github.com/ferrocene/ferrocene) ([Related PR](ferrocene/ferrocene#618)). Recently several PRs have landed improving the state of this target: * rust-lang#125220 * rust-lang#125669 * rust-lang#126355 * rust-lang#126279 * rust-lang#126707 * rust-lang#126916 * rust-lang#126917 * rust-lang#127280 * rust-lang#127967 The result has been that `riscv64gc-unknown-linux-gnu` now *should* pass the same CI tests that `x86_64-unknown-linux-gnu` and `aarch64-unknown-linux-gnu` do. ## Testing > [!NOTE] > While `riscv64gc-unknown-linux-gnu` is a [**Tier 2 with Host Tools** platform](https://doc.rust-lang.org/beta/rustc/platform-support.html) (meaning all tests may not necessarily pass) we do need to see all of the tests passing here. Indeed, the point of this PR is to get `riscv64gc-unknown-linux-gnu` into automated testing so the tests can *remain* working. You can test out the job locally: ```sh DEPLOY=1 ./src/ci/docker/run.sh riscv64gc-gnu ``` `DEPLOY=1` helps reproduce the CI's environment and also avoids the chance of a `llvm-c/BitReader.h` error (detailed in rust-lang#85424 and rust-lang#56650). try-job: riscv64gc-gnu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with @Hoverbear, we've been improving the state of the riscv64gc-unknown-linux-gnu target.
This is in relation to #125220 where
tests/ui/debuginfo/debuginfo-emit-llvm-ir-and-split-debuginfo.rswas disabled for RISC-V 64 in that another test,tests/run-make/split-debuginfoalso needs to be disabled due to llvm/llvm-project#56642 and the changes made in #120518.This test appears to be a host test, not a target test, so it isn't seen failing in #126641, however, we are in the process of testing host tools for riscv64-gc-unknown-linux-gnu so this test has now been noticed to be a problem.