Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #127846

Closed
wants to merge 12 commits into from
Closed

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    d1a3c1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37295e6 View commit details
    Browse the repository at this point in the history
  3. allow(unsafe_op_in_unsafe_fn) on some functions

    These need to get their safety story straight
    ChrisDenton committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5922234 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Remove slice_to_end

    ChrisDenton committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    55c84e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14ae11f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10b845c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    a33abbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2043de1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0585c4a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#127003 - GrigorenkoPV:107975, r=SparrowLii

    Add a test for rust-lang#107975
    
    The int is zero. But also not zero. This is so much fun.
    
    This is a part of rust-lang#105107.
    
    Initially I was going to just rebase rust-lang#108445, but quite a few things changed since then:
    * The [mcve](rust-lang#105787 (comment)) used for rust-lang#105787 got fixed.[^upd2]
    * You can't just `a ?= b` for rust-lang#107975 anymore. Now you have to `a-b ?= 0`. This is what this PR does. As an additional flex, it show that three ways of converting a pointer to its address have this issue:
      1. `as usize`
      2. `.expose_provenance()`
      3. `.addr()`
    * rust-lang#108425 simply got fixed. Yay.
    
    As an aside, the naming for `addr_of!` is quite unfortunate in context of provenance APIs. Because `addr_of!` gives you a pointer, but what provenance APIs refer to as "address" is the `usize` value. Oh well.
    
    UPD1: GitHub is incapable of parsing rust-lang#107975 in the PR name, so let's add it here.
    
    [^upd2]: UPD2: [The other mcve](rust-lang#105787 (comment)) does not work anymore either, saying "this behavior recently changed as a result of a bug fix; see rust-lang#56105 for details."
    tgross35 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    169e1c2 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#127763 - ChrisDenton:safe-unsafe-unsafe, r=…

    …tgross35
    
    Make more Windows functions `#![deny(unsafe_op_in_unsafe_fn)]`
    
    As part of rust-lang#127747, I've evaluated some more Windows functions and added `unsafe` blocks where necessary. Some are just trivial wrappers that "inherit" the full unsafety of their function, but for others I've added some safety comments. A few functions weren't actually unsafe at all. I think they were just using `unsafe fn` to avoid an `unsafe {}` block.
    
    I'm not touching `c.rs` yet because that is partially being addressed by another PR and also I have plans to further reduce the number of wrapper functions we have in there.
    
    r? libs
    tgross35 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e1e6065 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127813 - ChrisDenton:win-futex, r=joboet

    Prevent double reference in generic futex
    
    In the Windows futex implementation we were a little lax at allowing references to references (i.e. `&&`) which can lead to deadlocks due to reading the wrong memory address. This uses a trait to tighten the constraints and ensure this doesn't happen.
    
    r? libs
    tgross35 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8352966 View commit details
    Browse the repository at this point in the history