Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crate name validation #127581

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix crate name validation #127581

wants to merge 4 commits into from
+230 −151

Commits on Sep 13, 2024

  1. Clean up rustc_session::output::{find,validate}_crate_name

    @fmease
    fmease committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6d1a322 View commit details
    Browse the repository at this point in the history

  2. Create UI test directory for CLI tests 

    Note that `need-crate-arg-ignore-tidy$x.rs` used to be in `tests/ui/command/`
which wasn't 'correct' as that directory concerns `std::process::Command` tests
not CLI tests.
    @fmease
    fmease committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fb151e7 View commit details
    Browse the repository at this point in the history

  3. Move #![crate_type] UI tests into attributes directory 

    Gets rid of two top-level UI tests which is always great.
    @fmease
    fmease committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2adcf6a View commit details
    Browse the repository at this point in the history

  4. Reject macro calls inside of #![crate_name]

    @fmease
    fmease committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    29a5379 View commit details
    Browse the repository at this point in the history