Show fnsig's unit output explicitly when there is output diff in diagnostics #127417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
chenyukang
force-pushed
the
yukang-method-output-diff
branch
from
7145cb1 to
edd1006
Compare
chenyukang
changed the title
oli-obk
reviewed
Jul 6, 2024
oli-obk
reviewed
Jul 6, 2024
| @@ -39,7 +39,7 @@ note: type in trait | |||
| LL | fn bar(self) -> Option<()>; | |||
| | ^^^^^^^^^^ | |||
| = note: expected signature `fn(MyFuture) -> Option<()>` | |||
| found signature `fn(MyFuture)` | |||
| found signature `fn(MyFuture) -> ()` | |||
There was a problem hiding this comment.
Not sure how I feel about those... but seems ok
|
Needs a rebase |
chenyukang
force-pushed
the
yukang-method-output-diff
branch
from
f3086b7 to
81c86dd
Compare
chenyukang
changed the title
|
@bors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 6, 2024
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#127386 (Uplift outlives components to `rustc_type_ir`) - rust-lang#127405 (uplift `PredicateEmittingRelation`) - rust-lang#127410 (Correct description of E0502) - rust-lang#127417 (Show fnsig's unit output explicitly when there is output diff in diagnostics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 6, 2024
Rollup merge of rust-lang#127417 - chenyukang:yukang-method-output-diff, r=oli-obk Show fnsig's unit output explicitly when there is output diff in diagnostics Fixes rust-lang#127263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127263