Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #127046

Closed
wants to merge 38 commits into from

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jieyouxu and others added 30 commits April 17, 2024 19:23
- Syntax extensions are replaced by proc macros.
- Add rationale for why AST validation pass need to be run
  post-expansion and why the pass is needed in the first place.
This commit was obtained by repeatedly inlining and simplifying.
It is only implemented for a single type. Directly passing this type is
simpler and avoids overhead from indirect calls.
It can be retrieved from the Session too.
They are not representable by Cranelift
This commit too was obtained by repeatedly inlining and simplifying.
as request T-lang is requesting some major changes in the lint inner
workings in rust-lang#126768#issuecomment-2192634762
These table entries have wrong number of columns so the "notes" field is
missing from the rendered page. Fix by removing excess empty columns.
…ler-errors

Various rustc_codegen_ssa cleanups
Add test for fn pointer duplication.

I managed to make it fail when removing provenance checks in GVN.

cc rust-lang#123670

r? `@oli-obk`
…docs, r=wesleywiser

Update AST validation module docs

Drive-by doc update for AST validation pass:

- Syntax extensions are replaced by proc macros.
- Add rationale for why AST validation pass need to be run
  post-expansion and why the pass is needed in the first place.

This was discussed during this week's [rustc-dev-guide reading club](https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide), and the rationale was explained by cc `@bjorn3.`
…atthewjasper

Simplifications in match lowering

A series of small simplifications and deduplications in the MIR lowering of patterns.

r? `@matthewjasper`
…ive, r=oli-obk

Add basic Serde serialization capabilities to Stable MIR

This PR adds basic Serde serialization capabilities to Stable MIR. It is intentionally minimal (just wrapping all stable MIR types with a Serde `derive`), so that any important design decisions can be discussed before going further. A simple test is included with this PR to validate that JSON can actually be emitted.

## Notes

When I wrapped the Stable MIR error types in `compiler/stable_mir/src/error.rs`, it caused test failures (though I'm not sure why) so I backed those out.

## Future Work

So, this PR will support serializing basic stable MIR, but it _does not_ support serializing interned values beneath `Ty`s and `AllocId`s, etc... My current thinking about how to handle this is as follows:

1.  Add new `visited_X` fields to the `Tables` struct for each interned category of interest.

2.  As serialization is occuring, serialize interned values as usual _and_ also record the interned value we referenced in `visited_X`.

    (Possibly) In addition, if an interned value recursively references other interned values, record those interned values as well.

3.  Teach the stable MIR `Context` how to access the `visited_X` values and expose them with wrappers in `stable_mir/src/lib.rs` to users (e.g. to serialize and/or further analyze them).

### Pros

This approach does not commit to any specific serialization format regarding interned values or other more complex cases, which avoids us locking into any behaviors that may not be desired long-term.

### Cons

The user will need to manually handle serializing interned values.

### Alternatives

1.  We can directly provide access to the underlying `Tables` maps for interned values; the disadvantage of this approach is that it either requires extra processing for users to filter out to only use the values that they need _or_ users may serialize extra values that they don't need. The advantage is that the implementation is even simpler. The other pros/cons are similar to the above.

2.  We can directly serialize interned values by expanding them in-place. The pro is that this may make some basic inputs easier to consume. However, the cons are that there will need to be special provisions for dealing with cyclical values on both the producer and consumer _and_ global values will possibly need to be de-duplicated on the consumer side.
…=notriddle

Update browser-ui-test version to `0.18.0`

Should help with rust-lang#126436.

r? `@notriddle`
Switch back `non_local_definitions` lint to allow-by-default

This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.
…ez,notriddle

docs: check if the disambiguator matches its suffix

Fixes rust-lang#126986

This PR makes it will not continue resolving when its disambiguator doesn't match the suffix format.
…r=lqd

Fix Markdown tables in platform-support.md

These table entries have wrong number of columns so the "notes" field is missing from the rendered page. Fix by removing excess empty columns.
… r=oli-obk

Enable const casting for `f16` and `f128`

I have an open PR to the Miri repo adding tests for this behavior rust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version of rust-lang/miri#3688.

Cc `@RalfJung`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 27, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jun 27, 2024

📌 Commit e23f6b0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024
@bors
Copy link
Contributor

bors commented Jun 27, 2024

⌛ Testing commit e23f6b0 with merge 2cb0ec8...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2024
…llaumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#123237 (Various rustc_codegen_ssa cleanups)
 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#126835 (Simplifications in match lowering)
 - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
 - rust-lang#127010 (Update browser-ui-test version to `0.18.0`)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-stable failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs stdout ----
diff of stderr:

4 LL | //! [struct@m!()]
6    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
8    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
8    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
9 
10 warning: unmatched disambiguator `struct` and suffix `()`

13 LL | //! [struct@f()]
15    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
17 
17 
18 warning: unmatched disambiguator `struct` and suffix `!`
19   --> $DIR/disambiguator-endswith-named-suffix.rs:7:6

21 LL | //! [struct@m!]
23    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
25 
25 
26 warning: unmatched disambiguator `enum` and suffix `!()`


29 LL | //! [enum@m!()]
31    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
33 
33 
34 warning: unmatched disambiguator `enum` and suffix `()`
35   --> $DIR/disambiguator-endswith-named-suffix.rs:12:6

37 LL | //! [enum@f()]
39    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
41 
41 
42 warning: unmatched disambiguator `enum` and suffix `!`
43   --> $DIR/disambiguator-endswith-named-suffix.rs:13:6

45 LL | //! [enum@m!]
47    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
49 
49 
50 warning: unmatched disambiguator `trait` and suffix `!()`


53 LL | //! [trait@m!()]
55    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
57 
57 
58 warning: unmatched disambiguator `trait` and suffix `()`
59   --> $DIR/disambiguator-endswith-named-suffix.rs:18:6

61 LL | //! [trait@f()]
63    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
65 
65 
66 warning: unmatched disambiguator `trait` and suffix `!`
67   --> $DIR/disambiguator-endswith-named-suffix.rs:19:6

69 LL | //! [trait@m!]
71    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
73 
73 
74 warning: unmatched disambiguator `module` and suffix `!()`


77 LL | //! [module@m!()]
79    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
81 
81 
82 warning: unmatched disambiguator `module` and suffix `()`


85 LL | //! [module@f()]
87    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
89 
89 
90 warning: unmatched disambiguator `module` and suffix `!`


93 LL | //! [module@m!]
95    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
97 
97 
98 warning: unmatched disambiguator `mod` and suffix `!()`


101 LL | //! [mod@m!()]
103    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
105 
105 
106 warning: unmatched disambiguator `mod` and suffix `()`


109 LL | //! [mod@f()]
111    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
113 
113 
114 warning: unmatched disambiguator `mod` and suffix `!`


117 LL | //! [mod@m!]
119    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
121 
121 
122 warning: unmatched disambiguator `const` and suffix `!()`


125 LL | //! [const@m!()]
127    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
129 
129 
130 warning: incompatible link kind for `f`
131   --> $DIR/disambiguator-endswith-named-suffix.rs:36:6

145 LL | //! [const@m!]
147    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
149 
149 
150 warning: unmatched disambiguator `constant` and suffix `!()`


153 LL | //! [constant@m!()]
155    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
157 
157 
158 warning: incompatible link kind for `f`
159   --> $DIR/disambiguator-endswith-named-suffix.rs:42:6

173 LL | //! [constant@m!]
175    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
177 
177 
178 warning: unmatched disambiguator `static` and suffix `!()`


181 LL | //! [static@m!()]
183    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
185 
185 
186 warning: incompatible link kind for `f`
187   --> $DIR/disambiguator-endswith-named-suffix.rs:48:6

201 LL | //! [static@m!]
203    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
205 
205 
206 warning: unmatched disambiguator `function` and suffix `!()`


209 LL | //! [function@m!()]
211    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
213 
213 
214 warning: unmatched disambiguator `function` and suffix `!`


217 LL | //! [function@m!]
219    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
221 
221 
222 warning: unmatched disambiguator `fn` and suffix `!()`


225 LL | //! [fn@m!()]
227    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
229 
229 
230 warning: unmatched disambiguator `fn` and suffix `!`


233 LL | //! [fn@m!]
235    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
237 
237 
238 warning: unmatched disambiguator `method` and suffix `!()`


241 LL | //! [method@m!()]
243    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
245 
245 
246 warning: unmatched disambiguator `method` and suffix `!`


249 LL | //! [method@m!]
251    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
253 
253 
254 warning: incompatible link kind for `m`
255   --> $DIR/disambiguator-endswith-named-suffix.rs:69:6

281 LL | //! [derive@f()]
283    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
285 
285 
286 warning: incompatible link kind for `m`
287   --> $DIR/disambiguator-endswith-named-suffix.rs:73:6

301 LL | //! [type@m!()]
303    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
305 
305 
306 warning: unmatched disambiguator `type` and suffix `()`
307   --> $DIR/disambiguator-endswith-named-suffix.rs:78:6

309 LL | //! [type@f()]
311    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
313 
313 
314 warning: unmatched disambiguator `type` and suffix `!`
315   --> $DIR/disambiguator-endswith-named-suffix.rs:79:6

317 LL | //! [type@m!]
319    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
321 
321 
322 warning: unmatched disambiguator `value` and suffix `!()`


325 LL | //! [value@m!()]
327    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
329 
329 
330 warning: unmatched disambiguator `value` and suffix `!`
331   --> $DIR/disambiguator-endswith-named-suffix.rs:85:6

333 LL | //! [value@m!]
335    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
337 
337 
338 warning: unmatched disambiguator `macro` and suffix `()`
339   --> $DIR/disambiguator-endswith-named-suffix.rs:90:6

341 LL | //! [macro@f()]
343    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
345 
345 
346 warning: unmatched disambiguator `prim` and suffix `!()`


349 LL | //! [prim@m!()]
351    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
353 
353 
354 warning: unmatched disambiguator `prim` and suffix `()`


357 LL | //! [prim@f()]
359    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
361 
361 
362 warning: unmatched disambiguator `prim` and suffix `!`


365 LL | //! [prim@m!]
367    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
369 
369 
370 warning: unmatched disambiguator `primitive` and suffix `!()`


373 LL | //! [primitive@m!()]
375    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
377 
377 
378 warning: unmatched disambiguator `primitive` and suffix `()`
379   --> $DIR/disambiguator-endswith-named-suffix.rs:102:6

381 LL | //! [primitive@f()]
383    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
385 
385 
386 warning: unmatched disambiguator `primitive` and suffix `!`
387   --> $DIR/disambiguator-endswith-named-suffix.rs:103:6

389 LL | //! [primitive@m!]
391    |
-    = note: see https://doc.rust-lang.org/nightly/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
+    = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
393 
---
To only update this specific test, also pass `--test-args disambiguator-endswith-named-suffix.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/disambiguator-endswith-named-suffix" "-A" "internal_features" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/disambiguator-endswith-named-suffix/auxiliary"
--- stderr -------------------------------
--- stderr -------------------------------
warning: unmatched disambiguator `struct` and suffix `!()`
   |
   |
LL | //! [struct@m!()]   //~ WARN: unmatched disambiguator `struct` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators
   = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default


warning: unmatched disambiguator `struct` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:6:6
   |
LL | //! [struct@f()]    //~ WARN: unmatched disambiguator `struct` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `struct` and suffix `!`
warning: unmatched disambiguator `struct` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:7:6
   |
LL | //! [struct@m!]     //~ WARN: unmatched disambiguator `struct` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `enum` and suffix `!()`
   |
   |
LL | //! [enum@m!()]     //~ WARN: unmatched disambiguator `enum` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `enum` and suffix `()`
warning: unmatched disambiguator `enum` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:12:6
   |
LL | //! [enum@f()]      //~ WARN: unmatched disambiguator `enum` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `enum` and suffix `!`
warning: unmatched disambiguator `enum` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:13:6
   |
LL | //! [enum@m!]       //~ WARN: unmatched disambiguator `enum` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `trait` and suffix `!()`
   |
   |
LL | //! [trait@m!()]    //~ WARN: unmatched disambiguator `trait` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `trait` and suffix `()`
warning: unmatched disambiguator `trait` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:18:6
   |
LL | //! [trait@f()]     //~ WARN: unmatched disambiguator `trait` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `trait` and suffix `!`
warning: unmatched disambiguator `trait` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:19:6
   |
LL | //! [trait@m!]      //~ WARN: unmatched disambiguator `trait` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `module` and suffix `!()`
   |
   |
LL | //! [module@m!()]   //~ WARN: unmatched disambiguator `module` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `module` and suffix `()`
   |
   |
LL | //! [module@f()]    //~ WARN: unmatched disambiguator `module` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `module` and suffix `!`
   |
   |
LL | //! [module@m!]     //~ WARN: unmatched disambiguator `module` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `mod` and suffix `!()`
   |
   |
LL | //! [mod@m!()]      //~ WARN: unmatched disambiguator `mod` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `mod` and suffix `()`
   |
   |
LL | //! [mod@f()]       //~ WARN: unmatched disambiguator `mod` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `mod` and suffix `!`
   |
   |
LL | //! [mod@m!]        //~ WARN: unmatched disambiguator `mod` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `const` and suffix `!()`
   |
   |
LL | //! [const@m!()]    //~ WARN: unmatched disambiguator `const` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: incompatible link kind for `f`
warning: incompatible link kind for `f`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:36:6
   |
LL | //! [const@f()]     //~ WARN: incompatible link kind for `f`
   |
help: to link to the function, add parentheses
   |
   |
LL - //! [const@f()]     //~ WARN: incompatible link kind for `f`
LL + //! [f()]     //~ WARN: incompatible link kind for `f`

warning: unmatched disambiguator `const` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:37:6
   |
   |
LL | //! [const@m!]      //~ WARN: unmatched disambiguator `const` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `constant` and suffix `!()`
   |
   |
LL | //! [constant@m!()]   //~ WARN: unmatched disambiguator `constant` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: incompatible link kind for `f`
warning: incompatible link kind for `f`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:42:6
   |
LL | //! [constant@f()]    //~ WARN: incompatible link kind for `f`
   |
help: to link to the function, add parentheses
   |
   |
LL - //! [constant@f()]    //~ WARN: incompatible link kind for `f`
LL + //! [f()]    //~ WARN: incompatible link kind for `f`

warning: unmatched disambiguator `constant` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:43:6
   |
   |
LL | //! [constant@m!]     //~ WARN: unmatched disambiguator `constant` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `static` and suffix `!()`
   |
   |
LL | //! [static@m!()]   //~ WARN: unmatched disambiguator `static` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: incompatible link kind for `f`
warning: incompatible link kind for `f`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:48:6
   |
LL | //! [static@f()]    //~ WARN: incompatible link kind for `f`
   |
help: to link to the function, add parentheses
   |
   |
LL - //! [static@f()]    //~ WARN: incompatible link kind for `f`
LL + //! [f()]    //~ WARN: incompatible link kind for `f`

warning: unmatched disambiguator `static` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:49:6
   |
   |
LL | //! [static@m!]     //~ WARN: unmatched disambiguator `static` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `function` and suffix `!()`
   |
   |
LL | //! [function@m!()]   //~ WARN: unmatched disambiguator `function` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `function` and suffix `!`
   |
   |
LL | //! [function@m!]     //~ WARN: unmatched disambiguator `function` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `fn` and suffix `!()`
   |
   |
LL | //! [fn@m!()]   //~ WARN: unmatched disambiguator `fn` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `fn` and suffix `!`
   |
   |
LL | //! [fn@m!]     //~ WARN: unmatched disambiguator `fn` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `method` and suffix `!()`
   |
   |
LL | //! [method@m!()]   //~ WARN: unmatched disambiguator `method` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `method` and suffix `!`
   |
   |
LL | //! [method@m!]     //~ WARN: unmatched disambiguator `method` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: incompatible link kind for `m`
warning: incompatible link kind for `m`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:69:6
   |
LL | //! [derive@m!()]   //~ WARN: incompatible link kind for `m`
   |      ^^^^^^^^^^^ this link resolved to a macro, which is not a derive macro
help: to link to the macro, add an exclamation mark
   |
   |
LL - //! [derive@m!()]   //~ WARN: incompatible link kind for `m`
LL + //! [m!!()]   //~ WARN: incompatible link kind for `m`

warning: incompatible link kind for `m`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:70:6
   |
   |
LL | //! [derive@m!{}]   //~ WARN: incompatible link kind for `m`
   |      ^^^^^^^^^^^ this link resolved to a macro, which is not a derive macro
help: to link to the macro, add an exclamation mark
   |
   |
LL - //! [derive@m!{}]   //~ WARN: incompatible link kind for `m`
LL + //! [m!!{}]   //~ WARN: incompatible link kind for `m`

warning: unmatched disambiguator `derive` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:72:6
   |
   |
LL | //! [derive@f()]    //~ WARN: unmatched disambiguator `derive` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: incompatible link kind for `m`
warning: incompatible link kind for `m`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:73:6
   |
LL | //! [derive@m!]     //~ WARN: incompatible link kind for `m`
   |      ^^^^^^^^^ this link resolved to a macro, which is not a derive macro
help: to link to the macro, add an exclamation mark
   |
   |
LL - //! [derive@m!]     //~ WARN: incompatible link kind for `m`
LL + //! [m!!]     //~ WARN: incompatible link kind for `m`


warning: unmatched disambiguator `type` and suffix `!()`
   |
   |
LL | //! [type@m!()]   //~ WARN: unmatched disambiguator `type` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `type` and suffix `()`
warning: unmatched disambiguator `type` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:78:6
   |
LL | //! [type@f()]    //~ WARN: unmatched disambiguator `type` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `type` and suffix `!`
warning: unmatched disambiguator `type` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:79:6
   |
LL | //! [type@m!]     //~ WARN: unmatched disambiguator `type` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `value` and suffix `!()`
   |
   |
LL | //! [value@m!()]   //~ WARN: unmatched disambiguator `value` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `value` and suffix `!`
warning: unmatched disambiguator `value` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:85:6
   |
LL | //! [value@m!]     //~ WARN: unmatched disambiguator `value` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `macro` and suffix `()`
warning: unmatched disambiguator `macro` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:90:6
   |
LL | //! [macro@f()]    //~ WARN: unmatched disambiguator `macro` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `prim` and suffix `!()`
   |
   |
LL | //! [prim@m!()]   //~ WARN: unmatched disambiguator `prim` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `prim` and suffix `()`
   |
   |
LL | //! [prim@f()]    //~ WARN: unmatched disambiguator `prim` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `prim` and suffix `!`
   |
   |
LL | //! [prim@m!]     //~ WARN: unmatched disambiguator `prim` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators


warning: unmatched disambiguator `primitive` and suffix `!()`
   |
   |
LL | //! [primitive@m!()]   //~ WARN: unmatched disambiguator `primitive` and suffix `!()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `primitive` and suffix `()`
warning: unmatched disambiguator `primitive` and suffix `()`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:102:6
   |
LL | //! [primitive@f()]    //~ WARN: unmatched disambiguator `primitive` and suffix `()`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: unmatched disambiguator `primitive` and suffix `!`
warning: unmatched disambiguator `primitive` and suffix `!`
##[warning]  --> /checkout/tests/rustdoc-ui/disambiguator-endswith-named-suffix.rs:103:6
   |
LL | //! [primitive@m!]     //~ WARN: unmatched disambiguator `primitive` and suffix `!`
   |
   = note: see https://doc.rust-lang.org/1.81.0/rustdoc/write-documentation/linking-to-items-by-name.html#namespaces-and-disambiguators for more info about disambiguators

warning: 46 warnings emitted

@bors
Copy link
Contributor

bors commented Jun 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2024
@GuillaumeGomez GuillaumeGomez deleted the rollup-zny4j7m branch June 27, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.