Use Cow<'static, str> for InlineAsmTemplatePiece::String #126908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
Skgland
reviewed
Jun 24, 2024
GnomedDev
force-pushed
the
cow-inline-asm-temp-piece
branch
from
4d4f137
to
4bc8ec3
Compare
|
☔ The latest upstream changes (presumably #127162) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me, needs a rebase tho @rustbot author |
rustbot
added
S-waiting-on-author
GnomedDev
force-pushed
the
cow-inline-asm-temp-piece
branch
from
4bc8ec3
to
d58dc2a
Compare
|
Missed this, rebased now. @rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GnomedDev
force-pushed
the
cow-inline-asm-temp-piece
branch
from
d58dc2a
to
db8cdc5
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 25, 2024
…e, r=compiler-errors Use Cow<'static, str> for InlineAsmTemplatePiece::String This removes a bunch of `&'static str -> String` allocations in codegen cranelift.
This was referenced Jul 25, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#126908 (Use Cow<'static, str> for InlineAsmTemplatePiece::String) - rust-lang#127999 (Inject arm32 shims into Windows metadata generation) - rust-lang#128137 (CStr: derive PartialEq, Eq; add test for Ord) - rust-lang#128185 (Fix a span error when parsing a wrong param of function.) - rust-lang#128187 (Fix 1.80.0 version in RELEASES.md) - rust-lang#128189 (Turn an unreachable code path into an ICE) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2024
Rollup merge of rust-lang#126908 - GnomedDev:cow-inline-asm-temp-piece, r=compiler-errors Use Cow<'static, str> for InlineAsmTemplatePiece::String This removes a bunch of `&'static str -> String` allocations in codegen cranelift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a bunch of
&'static str -> Stringallocations in codegen cranelift.