Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all &DiagCtxt with a DiagCtxtHandle<'_> wrapper type #126623

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Replace all &DiagCtxt with a DiagCtxtHandle<'_> wrapper type #126623

merged 4 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. Use a more precise lifetime

    @oli-obk
    oli-obk committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7e58930 View commit details
    Browse the repository at this point in the history

  2. Prefer dcx methods over fields or fields' methods

    @oli-obk
    oli-obk committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c91edc3 View commit details
    Browse the repository at this point in the history

  3. Use a dedicated type instead of a reference for the diagnostic context 

    This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle
    @oli-obk
    oli-obk committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7ba82d6 View commit details
    Browse the repository at this point in the history

  4. Remove redundant argument from subdiagnostic method

    @oli-obk
    oli-obk committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3f34196 View commit details
    Browse the repository at this point in the history