Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #126412

Closed
wants to merge 23 commits into from

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    5cfe020 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Remove some msys2 utils

    ChrisDenton committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    48d3425 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. std::unix::fs::link using direct linkat call for Solaris and macOs.

    Since we support solaris 11 and macOs Sierra as minimum, we can get rid
    of the runtime overhead.
    devnexen committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c81ffab View commit details
    Browse the repository at this point in the history
  2. Use -Zno-profiler-runtime instead of //@ needs-profiler-support

    For PGO/coverage tests that don't need to build or run an actual artifact, we
    can use `-Zno-profiler-runtime` to run the test even when the profiler runtime
    is not available.
    Zalathar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a84f754 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c67f32 View commit details
    Browse the repository at this point in the history
  4. Remove //@ ignore-windows-gnu from tests that need the profiler

    The profiler runtime is no longer built in mingw test jobs, so these tests
    should naturally be skipped by `//@ needs-profiler-support`.
    Zalathar committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d2ecfbb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    beb45a4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2733b8a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a621701 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ece3e3e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e8d6170 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7566307 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b28221e View commit details
    Browse the repository at this point in the history
  12. Add some tests

    oli-obk committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c75f728 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9cf60ee View commit details
    Browse the repository at this point in the history
  14. extend the check for LLVM build

    We don't build LLVM when using the precompiled version from the CI builder.
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    58e3ac0 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#121216 - madsmtm:fix-108825, r=wesleywiser

    Always emit `native-static-libs` note, even if it is empty
    
    Fixes rust-lang#108825.
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    32b7592 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#122613 - Zalathar:profiler, r=nnethercote

    Don't build a broken/untested profiler runtime on mingw targets
    
    Context: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Why.20build.20a.20broken.2Funtested.20profiler.20runtime.20on.20mingw.3F
    
    rust-lang#75872 added `--enable-profiler` to the `x86_64-mingw` job (to cause some additional tests to run), but had to also add `//@ ignore-windows-gnu` to all of the tests that rely on the profiler runtime actually *working*, because it's broken on that target.
    
    We can achieve a similar outcome by going through all the `//@ needs-profiler-support` tests that don't actually need to produce/run a binary, and making them use `-Zno-profiler-runtime` instead, so that they can run even in configurations that don't have the profiler runtime available. Then we can remove `--enable-profiler` from `x86_64-mingw`, and still get the same amount of testing.
    
    This PR also removes `--enable-profiler` from the mingw dist builds, since it is broken/untested on that target. Those builds have had that flag for a very long time.
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7a1deaf View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#123962 - oli-obk:define_opaque_types5, r=lcnr

    change method resolution to constrain hidden types instead of rejecting method candidates
    
    Some of these are in probes and may affect inference. This is therefore a breaking change.
    
    This allows new code to compile on stable:
    
    ```rust
    trait Trait {}
    
    impl Trait for u32 {}
    
    struct Bar<T>(T);
    
    impl Bar<u32> {
        fn foo(self) {}
    }
    
    fn foo(x: bool) -> Bar<impl Sized> {
        if x {
            let x = foo(false);
            x.foo();
            //^ this used to not find the `foo` method, because while we did equate `x`'s type with possible candidates, we didn't allow opaque type inference while doing so
        }
        todo!()
    }
    ```
    
    r? ``@compiler-errors``
    
    fixes  rust-lang#121404
    
    cc rust-lang#116652
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0650026 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#126320 - oli-obk:pat_ice, r=lcnr

    Avoid ICES after reporting errors on erroneous patterns
    
    fixes rust-lang#109812
    fixes rust-lang#125914
    fixes rust-lang#124004
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    29cb7a9 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#126343 - ChrisDenton:remove-utils, r=Kobzol

    Remove some msys2 utils
    
    `dos2unix` should no longer be necessary. I suspect `diffutils` might not be needed either as (I think) only `diff` is used and that seems to be shipped with git bash at least.
    
    try-job: x86_64-msvc
    try-job: x86_64-msvc-ext
    try-job: dist-x86_64-msvc
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c9d783e View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#126351 - devnexen:to_sol11_upd, r=ChrisDenton

    std::unix::fs::link using direct linkat call for Solaris.
    
    Since we support solaris 11 as minimum, we can get rid of the runtime overhead.
    
    try-job: dist-various-2
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    d78706b View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#126399 - onur-ozkan:126156, r=albertlarsan68

    extend the check for LLVM build
    
    We don't build LLVM when using the precompiled version from the CI builder.
    
    Closes rust-lang#126156
    matthiaskrgr committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1521dc8 View commit details
    Browse the repository at this point in the history