Add hard error and migration lint for unsafe attrs #126177

carbotaniuman · 2024-06-08T23:45:37Z

More implementation work for #123757

This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

rustbot · 2024-06-08T23:45:45Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu

Thank you for working on this. The implementation looks good to me overall, I just have some questions and nits.

compiler/rustc_lint_defs/src/builtin.rs

jieyouxu · 2024-06-09T17:01:04Z

compiler/rustc_parse/messages.ftl

@@ -364,6 +364,10 @@ parse_inner_doc_comment_not_permitted = expected outer doc comment
    .label_does_not_annotate_this = the inner doc comment doesn't annotate this {$item}
    .sugg_change_inner_to_outer = to annotate the {$item}, change the doc comment from inner to outer style

+parse_invalid_attr_unsafe = `{$name}` is not an unsafe attribute
+    .suggestion = remove the `unsafe(...)`
+    .note = extraneous unsafe is not allowed in attributes


Discussion: should this say something like "unsafe attribute block is not permitted for safe attributes"?

compiler/rustc_parse/messages.ftl

compiler/rustc_parse/src/validate_attr.rs

jieyouxu · 2024-06-09T17:26:05Z

@rustbot author

carbotaniuman · 2024-06-16T07:56:16Z

@rustbot reviewer

jieyouxu

Thank you for working on this. The implementation looks good to me! Just one nit on the lint docs then r=me.

compiler/rustc_lint_defs/src/builtin.rs

compiler/rustc_parse/messages.ftl

@@ -364,6 +364,10 @@ parse_inner_doc_comment_not_permitted = expected outer doc comment
    .label_does_not_annotate_this = the inner doc comment doesn't annotate this {$item}
    .sugg_change_inner_to_outer = to annotate the {$item}, change the doc comment from inner to outer style

+parse_invalid_attr_unsafe = `{$name}` is not an unsafe attribute
+    .suggestion = remove the `unsafe(...)`
+    .note = extraneous unsafe is not allowed in attributes


jieyouxu · 2024-06-16T21:48:21Z

@rustbot author

bors · 2024-06-17T07:29:11Z

☔ The latest upstream changes (presumably #126569) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2024-06-17T16:55:13Z

r=me with a rebase, but not going to block on the tiny comment nit.

carbotaniuman · 2024-06-24T01:09:41Z

@rustbot reviewer

jieyouxu

Thanks!

jieyouxu · 2024-06-24T01:48:13Z

@bors r+

bors · 2024-06-24T01:48:15Z

📌 Commit a23917c has been approved by jieyouxu

It is now in the queue for this repository.

…r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#126177 (Add hard error and migration lint for unsafe attrs) - rust-lang#126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools) - rust-lang#126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.) - rust-lang#126754 (Implement `use<>` formatting in rustfmt) - rust-lang#126807 (std::unix::fs: copy simplification for apple.) - rust-lang#126845 (Weekly `cargo update`) - rust-lang#126849 (Fix 32-bit Arm reg classes by hierarchically sorting them) - rust-lang#126854 (std::unix::os::home_dir: fallback's optimisation.) - rust-lang#126861 (Migrate `run-make/invalid-library` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126177 (Add hard error and migration lint for unsafe attrs) - rust-lang#126298 (Promote loongarch64-unknown-linux-musl to Tier 2 with host tools) - rust-lang#126455 (For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it.) - rust-lang#126754 (Implement `use<>` formatting in rustfmt) - rust-lang#126807 (std::unix::fs: copy simplification for apple.) - rust-lang#126845 (Weekly `cargo update`) - rust-lang#126849 (Fix 32-bit Arm reg classes by hierarchically sorting them) - rust-lang#126854 (std::unix::os::home_dir: fallback's optimisation.) - rust-lang#126888 (Remove stray println from rustfmt's `rewrite_static`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126177 - carbotaniuman:unsafe_attr_errors, r=jieyouxu Add hard error and migration lint for unsafe attrs More implementation work for rust-lang#123757 This adds the migration lint for unsafe attributes, as well as making it a hard error in Rust 2024.

@Kobzol

Update Rust toolchain from nightly-2024-06-24 to nightly-2024-06-25 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@bcf94de up to rust-lang@6b0f4b5. The log for this commit range is: rust-lang@6b0f4b5ec3 Auto merge of rust-lang#126914 - compiler-errors:rollup-zx0hchm, r=compiler-errors rust-lang@16bd6e25e1 Rollup merge of rust-lang#126911 - oli-obk:do_not_count_errors, r=compiler-errors rust-lang@59c258f51f Rollup merge of rust-lang#126909 - onur-ozkan:add-kobzol, r=matthiaskrgr rust-lang@85eb835a14 Rollup merge of rust-lang#126904 - GrigorenkoPV:nonzero-fixme, r=joboet rust-lang@a7721a0373 Rollup merge of rust-lang#126899 - GrigorenkoPV:suggest-const-block, r=davidtwco rust-lang@9ce2a070b3 Rollup merge of rust-lang#126682 - Zalathar:coverage-attr, r=lcnr rust-lang@49bdf460a2 Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting, r=compiler-errors rust-lang@46e43984d1 Rollup merge of rust-lang#126413 - matthiaskrgr:crshmsg, r=oli-obk rust-lang@ed460d2eaa Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco rust-lang@c77dc28f87 Rollup merge of rust-lang#125082 - kpreid:const-uninit, r=dtolnay rust-lang@faa28be2f1 Rollup merge of rust-lang#124712 - Enselic:deprecate-inline-threshold, r=pnkfelix rust-lang@00e5f5886a Rollup merge of rust-lang#124460 - long-long-float:show-notice-about-enum-with-debug, r=pnkfelix rust-lang@d8d5732456 Auto merge of rust-lang#126784 - scottmcm:smaller-terminator, r=compiler-errors rust-lang@13fca73f49 Replace `MaybeUninit::uninit_array()` with array repeat expression. rust-lang@5a3e2a4e92 Auto merge of rust-lang#126523 - joboet:the_great_big_tls_refactor, r=Mark-Simulacrum rust-lang@45261ff2ec add @Kobzol to bootstrap team for triagebot rust-lang@84474a25a4 Small fixme in core now that NonZero is generic rust-lang@50a02ed789 std: fix wasm builds rust-lang@8fc6b3de19 Separate the mir body lifetime from the other lifetimes rust-lang@1c4d0ced58 Separate the lifetimes of the `BorrowckInferCtxt` from the other borrowed items rust-lang@d371d17496 Auto merge of rust-lang#126900 - matthiaskrgr:rollup-24ah97b, r=matthiaskrgr rust-lang@8ffb5f936a compiletest: make the crash test error message abit more informative rust-lang@a80ee9159b Rollup merge of rust-lang#126882 - estebank:multiline-order, r=WaffleLapkin rust-lang@8bfde609e2 Rollup merge of rust-lang#126414 - ChrisDenton:target-known, r=Nilstrieb rust-lang@94b9ea417d Rollup merge of rust-lang#126213 - zachs18:atomicbool-u8-i8-from-ptr-alignment, r=Nilstrieb rust-lang@9d24ecc37b Rollup merge of rust-lang#125241 - Veykril:tool-rust-analyzer, r=davidtwco rust-lang@ba5ec1fc5c Suggest inline const blocks for array initialization rust-lang@06c072f158 Auto merge of rust-lang#126788 - GuillaumeGomez:migrate-rustdoc-tests-syntax, r=fmease,oli-obk rust-lang@1852141219 coverage: Bless coverage attribute tests rust-lang@b7c057c9b2 coverage: Always error on `#[coverage(..)]` in unexpected places rust-lang@a000fa8b54 coverage: Tighten validation of `#[coverage(off)]` and `#[coverage(on)]` rust-lang@b5dfeba0e1 coverage: Forbid multiple `#[coverage(..)]` attributes rust-lang@6909feab8e Allow numbers in rustdoc tests commands rust-lang@4e258bb4c3 Fix tidy issue for rustdoc tests commands rust-lang@51fedf65ff Remove commands duplication between `compiletest` and `tests/rustdoc` rust-lang@1b67035579 Update `tests/rustdoc` to new test syntax rust-lang@d3ec92e16e Move `tests/rustdoc` testsuite to `//@` syntax rust-lang@2c243d9570 Auto merge of rust-lang#126891 - matthiaskrgr:rollup-p6dl1gk, r=matthiaskrgr rust-lang@b94d2754b5 Rollup merge of rust-lang#126888 - compiler-errors:oops-debug-printing, r=dtolnay rust-lang@9892b3e9fe Rollup merge of rust-lang#126854 - devnexen:std_unix_os_fallback_upd, r=Mark-Simulacrum rust-lang@3108dfaced Rollup merge of rust-lang#126849 - workingjubilee:correctly-classify-arm-low-dregs, r=Amanieu rust-lang@dcace866f0 Rollup merge of rust-lang#126845 - rust-lang:cargo_update, r=Mark-Simulacrum rust-lang@21850f5bd8 Rollup merge of rust-lang#126807 - devnexen:copy_file_macos_simpl, r=Mark-Simulacrum rust-lang@b24e3df0df Rollup merge of rust-lang#126754 - compiler-errors:use-rustfmt, r=calebcartwright rust-lang@ad0531ae0d Rollup merge of rust-lang#126455 - surechen:fix_126222, r=estebank rust-lang@7babf99ea9 Rollup merge of rust-lang#126298 - heiher:loongarch64-musl-ci, r=Mark-Simulacrum rust-lang@9a591ea1ce Rollup merge of rust-lang#126177 - carbotaniuman:unsafe_attr_errors, r=jieyouxu rust-lang@25446c25fc Remove stray println from rustfmt rust-lang@d49994b060 Auto merge of rust-lang#126023 - amandasystems:you-dropped-this-again, r=nikomatsakis rust-lang@a23917cfd0 Add hard error and migration lint for unsafe attrs rust-lang@284437d434 Special case when a code line only has multiline span starts rust-lang@f1be59fa72 SmartPointer derive-macro rust-lang@a426d6fdf0 Implement use<> formatting in rustfmt rust-lang@16fef40896 Promote loongarch64-unknown-linux-musl to Tier 2 with host tools rust-lang@03d73fa6ba ci: Add support for dist-loongarch64-musl rust-lang@fc50acae90 fix build rust-lang@bd9ce3e074 std::unix::os::home_dir: fallback's optimisation. rust-lang@0d8f734172 compiler: Fix arm32 asm issues by hierarchically sorting reg classes rust-lang@e8b5ba1111 For [E0308]: mismatched types, when expr is in an arm's body, not add semicolon ';' at the end of it. rust-lang@990535723d cargo update rust-lang@b28efb11af Save 2 pointers in `TerminatorKind` (96 → 80 bytes) rust-lang@65530ba100 std::unix::fs: copy simplification for apple. rust-lang@339015920d Add `rust_analyzer` as a predefined tool rust-lang@3f2f8438b4 Ensure we don't accidentally succeed when we want to report an error rust-lang@32f9b8bf76 std: rename module for clarity rust-lang@35f050b8da std: update TLS module documentation rust-lang@b2f29edc81 std: use the `c_int` from `core::ffi` instead of `libc` rust-lang@d70f071392 std: simplify `#[cfg]`s for TLS rust-lang@d630f5da7a Show notice about "never used" for enum rust-lang@f3facf1175 std: refactor the TLS implementation rust-lang@f5f067bf9d Deprecate no-op codegen option `-Cinline-threshold=...` rust-lang@651ff643ae Fix typo in `-Cno-stack-check` deprecation warning rust-lang@3af624272a rustc_codegen_ssa: Remove unused ModuleConfig::inline_threshold rust-lang@34e6ea1446 Tier 2 std support must always be known rust-lang@2d4cb7aa5a Update docs for AtomicU8/I8. rust-lang@7885c7b7b2 Update safety docs for AtomicBool::from_ptr. rust-lang@7b5b7a7010 Remove confusing `use_polonius` flag and do less cloning Co-authored-by: tautschnig <1144736+tautschnig@users.noreply.github.com>

rustbot assigned jieyouxu Jun 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2024

traviscross mentioned this pull request Jun 8, 2024

Tracking Issue for RFC 3325: unsafe attributes #123757

Closed

8 tasks

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from 643bc06 to 86c52d6 Compare June 9, 2024 00:23

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from 86c52d6 to e86eaae Compare June 9, 2024 01:18

This comment has been minimized.

Sign in to view

carbotaniuman force-pushed the unsafe_attr_errors branch from e86eaae to 9d329c0 Compare June 9, 2024 03:49

jieyouxu reviewed Jun 9, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024

jieyouxu added L-unsafe_attr_outside_unsafe Lint: unsafe_attr_outside_unsafe F-unsafe_attributes `#![feature(unsafe_attributes)]` labels Jun 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2024

jieyouxu approved these changes Jun 16, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024

ehuss mentioned this pull request Jun 20, 2024

Add 2024 unsafe attributes. rust-lang/edition-guide#308

Merged

carbotaniuman force-pushed the unsafe_attr_errors branch from 2d0a3dc to 6c14e9e Compare June 23, 2024 23:50

This comment has been minimized.

Sign in to view

Add hard error and migration lint for unsafe attrs

a23917c

carbotaniuman force-pushed the unsafe_attr_errors branch from 6c14e9e to a23917c Compare June 24, 2024 00:02

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024

jieyouxu approved these changes Jun 24, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2024

workingjubilee mentioned this pull request Jun 24, 2024

Rollup of 9 pull requests #126886

Closed

matthiaskrgr mentioned this pull request Jun 24, 2024

Rollup of 9 pull requests #126891

Merged

bors merged commit 9a591ea into rust-lang:master Jun 24, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hard error and migration lint for unsafe attrs #126177

Add hard error and migration lint for unsafe attrs #126177

carbotaniuman commented Jun 8, 2024

rustbot commented Jun 8, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

jieyouxu Jun 9, 2024

This comment was marked as resolved.

jieyouxu commented Jun 9, 2024

carbotaniuman commented Jun 16, 2024

jieyouxu left a comment •

edited

Loading

This comment was marked as resolved.

jieyouxu commented Jun 16, 2024

bors commented Jun 17, 2024

jieyouxu commented Jun 17, 2024 •

edited

Loading

This comment has been minimized.

carbotaniuman commented Jun 24, 2024

jieyouxu left a comment

jieyouxu commented Jun 24, 2024

bors commented Jun 24, 2024

Add hard error and migration lint for unsafe attrs #126177

Add hard error and migration lint for unsafe attrs #126177

Conversation

carbotaniuman commented Jun 8, 2024

rustbot commented Jun 8, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu Jun 9, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

jieyouxu commented Jun 9, 2024

carbotaniuman commented Jun 16, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

jieyouxu commented Jun 16, 2024

bors commented Jun 17, 2024

jieyouxu commented Jun 17, 2024 • edited Loading

This comment has been minimized.

carbotaniuman commented Jun 24, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Jun 24, 2024

bors commented Jun 24, 2024

jieyouxu left a comment •

edited

Loading

jieyouxu commented Jun 17, 2024 •

edited

Loading