Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use a native arm64 runner #126113

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 7, 2024

Opening to test if we can use a native GitHub ARM runner instead of the self-hosted one.

The CI has finished successfully. It took 1h 29m, which is longer than the previous duration (~1h 10m). This is expected, since we currently use 8 cores on GitHub, rather than 14 cores which are configured for the self-hosted runner.

try-job: aarch64-gnu

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 7, 2024
@workingjubilee
Copy link
Member

but what will I do with myself when PRs don't need to be babysat through periodic network fritzes and interruptions due to the spot-priced CI runner being reclaimed anymore?

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 7, 2024

@bors try

(Don't worry, the ARM runners are still in beta, so chances are that they will still need some babysitting :) )

@bors
Copy link
Contributor

bors commented Jun 7, 2024

⌛ Trying commit 1c4b0c4 with merge 6377331...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2024
[WIP] CI: use a native `arm64` runner

Opening as a draft to test if we can use a native GitHub ARM runner instead of the self-hosted one.

try-job: aarch64-gnu
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jun 7, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 7, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2024
[WIP] CI: use a native `arm64` runner

Opening as a draft to test if we can use a native GitHub ARM runner instead of the self-hosted one.

try-job: aarch64-gnu
@bors
Copy link
Contributor

bors commented Jun 7, 2024

⌛ Trying commit 1c4b0c4 with merge 94f8767...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jun 7, 2024

💔 Test failed - checks-actions

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 7, 2024

@bors try

@bors
Copy link
Contributor

bors commented Jun 7, 2024

⌛ Testing commit 447326f with merge faab6c3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2024
[WIP] CI: use a native `arm64` runner

Opening as a draft to test if we can use a native GitHub ARM runner instead of the self-hosted one.

try-job: aarch64-gnu
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol changed the title [WIP] CI: use a native arm64 runner CI: use a native arm64 runner Jun 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2024
CI: remove `Setup Python` action

This action was added recently in rust-lang#125590, but it shouldn't really be needed, as our CI was working fine before without it. Our base Ubuntu 20.04 images use Python 3.8, while this action installed Python 3.12, but we don't really need that.

Since this action does not support ARM yet, this blocks rust-lang#126113. See rust-lang#125590 (comment).

r? `@jdno`
@Kobzol Kobzol marked this pull request as ready for review June 8, 2024 11:40
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 8, 2024

@rustbot ready

r? @jdno

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2024
@rustbot rustbot assigned jdno and unassigned Mark-Simulacrum Jun 8, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 10, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2024
CI: use a native `arm64` runner

Opening to test if we can use a native GitHub ARM runner instead of the self-hosted one.

The CI has finished [successfully](https://github.com/rust-lang/rust/actions/runs/9414573751/job/25933776975?pr=126113). It took 1h 29m, which is longer than the previous duration (~1h 10m). This is expected, since we currently use 8 cores on GitHub, rather than 14 cores which are configured for the self-hosted runner.

try-job: aarch64-gnu
@bors
Copy link
Contributor

bors commented Jun 10, 2024

⌛ Trying commit f976a9b with merge 95795f5...

@bors
Copy link
Contributor

bors commented Jun 10, 2024

☀️ Try build successful - checks-actions
Build commit: 95795f5 (95795f51761380e67dbe26a168846aa3892af2da)

@jdno
Copy link
Member

jdno commented Jun 10, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jun 10, 2024

📌 Commit f976a9b has been approved by jdno

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2024
@bors
Copy link
Contributor

bors commented Jun 11, 2024

⌛ Testing commit f976a9b with merge aec67e2...

@bors
Copy link
Contributor

bors commented Jun 11, 2024

☀️ Test successful - checks-actions
Approved by: jdno
Pushing aec67e2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2024
@bors bors merged commit aec67e2 into rust-lang:master Jun 11, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 11, 2024
@Kobzol Kobzol deleted the ci-native-arm-runner branch June 11, 2024 06:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aec67e2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 6.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.1% [4.1%, 7.4%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.712s -> 677.913s (0.33%)
Artifact size: 320.06 MiB -> 320.07 MiB (0.00%)

flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jun 28, 2024
CI: remove `Setup Python` action

This action was added recently in rust-lang/rust#125590, but it shouldn't really be needed, as our CI was working fine before without it. Our base Ubuntu 20.04 images use Python 3.8, while this action installed Python 3.12, but we don't really need that.

Since this action does not support ARM yet, this blocks rust-lang/rust#126113. See rust-lang/rust#125590 (comment).

r? `@jdno`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants