Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] RIIR HtmlDocCk #125780

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] RIIR HtmlDocCk #125780

wants to merge 1 commit into from
+910 −314

Conversation

fmease
Copy link
Member

@fmease fmease commented May 30, 2024

For self-review. Very early.

r? ghost

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 30, 2024
@rustbot rustbot added A-meta Area: Issues about the rust-lang/rust repository. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 30, 2024
@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2024
@fmease fmease added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label May 30, 2024
@fmease fmease mentioned this pull request May 31, 2024
Open
@bors
Copy link
Contributor

bors commented Jun 10, 2024

☔ The latest upstream changes (presumably #126205) made this pull request unmergeable. Please resolve the merge conflicts.

@fmease fmease mentioned this pull request Jun 22, 2024
Merged
@fmease fmease mentioned this pull request Jul 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@bors
Auto merge of rust-lang#127968 - fmease:upd-jsondocck-directive-style…
9057c3f 
…, r=GuillaumeGomez

Update jsondocck directives to follow ui_test-style

Context: Comment chain in rust-lang#125813.
Follow-up to rust-lang#126788.
Use the same temporary approach of "double parsing" until we figure out how we want to support compiletest/ui_test directive "add-ons" for child test runners like HtmlDocCk and JsonDocCk.

I didn't touch much of jsondocck because I want to refactor it some other time (for robustness, maintainability and better diagnostics; basically by following a similar design of my WIP HtmlDocCk-next, cc rust-lang#125780).

r? `@GuillaumeGomez`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues about the rust-lang/rust repository. A-testsuite Area: The testsuite used to check the correctness of rustc rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmease @bors @rustbot