Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format #125674

Oneirical · 2024-05-28T17:58:54Z

Part of #121876 and the associated Google Summer of Code project.

try-job: x86_64-msvc

rustbot · 2024-05-28T17:59:03Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-05-28T17:59:05Z

Some changes occurred in run-make tests.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Oneirical · 2024-05-28T20:02:30Z

Supporting Windows symlinks requires importing symlink_file, only available on Windows. Writing std::os::windows on an OS that is not Windows results in an error.

The previous test simply ignored Windows. Is it pertinent to make this test work on Windows too?

src/tools/run-make-support/src/lib.rs

tests/run-make/symlinked-rlib/rmake.rs

jieyouxu · 2024-05-28T22:59:28Z

Supporting Windows symlinks requires importing symlink_file, only available on Windows. Writing std::os::windows on an OS that is not Windows results in an error.

The previous test simply ignored Windows. Is it pertinent to make this test work on Windows too?

I think that is reasonable, but it looks like you have cfg-enabled specific versions. I think you need #[cfg(target_family = "unix")] instead of target_os?

jieyouxu · 2024-05-28T23:00:06Z

@rustbot author

Oneirical · 2024-05-29T15:59:15Z

Changes applied, and once again the important of #[must_use] is highlighted.
@rustbot review

src/tools/run-make-support/src/lib.rs

tests/run-make/symlinked-rlib/rmake.rs

jieyouxu · 2024-05-29T17:34:18Z

Thanks, r=me after CI is green
@bors delegate+

bors · 2024-05-29T17:34:21Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-06-12T14:50:38Z

@rustbot review

jieyouxu · 2024-06-12T22:51:22Z

Let's run a msvc try job to double check:
@bors try

jieyouxu · 2024-06-12T22:51:51Z

r=me if the try job comes back green.

…r=<try> Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc

bors · 2024-06-12T22:52:33Z

⌛ Trying commit 2ac5faa with merge 274423a...

bors · 2024-06-13T00:24:00Z

☀️ Try build successful - checks-actions
Build commit: 274423a (274423a5b5c831de005e321701e7b3b5a378f2cb)

Oneirical · 2024-06-13T00:33:14Z

@bors r=@jieyouxu

bors · 2024-06-13T00:33:16Z

📌 Commit 2ac5faa has been approved by jieyouxu

It is now in the queue for this repository.

…, r=jieyouxu Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#125165 (Migrate `run-make/pgo-branch-weights` to `rmake`) - rust-lang#125674 (Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format) - rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails) - rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting) - rust-lang#126303 (Urls to docs in rust_hir) - rust-lang#126328 (Add Option::is_none_or) - rust-lang#126337 (Add test for walking order dependent opaque type behaviour) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126353 (Move `MatchAgainstFreshVars` to old solver) - rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs) - rust-lang#126362 (Make `try_from_target_usize` method public) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#125674 (Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format) - rust-lang#125688 (Walk into alias-eq nested goals even if normalization fails) - rust-lang#126142 (Harmonize using root or leaf obligation in trait error reporting) - rust-lang#126303 (Urls to docs in rust_hir) - rust-lang#126328 (Add Option::is_none_or) - rust-lang#126337 (Add test for walking order dependent opaque type behaviour) - rust-lang#126353 (Move `MatchAgainstFreshVars` to old solver) - rust-lang#126356 (docs(rustc): Improve discoverable of Cargo docs) - rust-lang#126358 (safe transmute: support `Single` enums) - rust-lang#126362 (Make `try_from_target_usize` method public) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#125674 - Oneirical:another-day-another-test, r=jieyouxu Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc

petrochenkov · 2024-06-22T14:06:17Z

@Oneirical @jieyouxu
These tests (symlinked-extern, symlinked-rlib, symlinked-libraries) are now failing on Windows for me.
The errors look like this:

thread 'main' panicked at C:\msys64\home\we\rust\src\tools\run-make-support\src\lib.rs:115:56:
failed to create symlink "other" for "libfoo.rlib": Os { code: 1314, kind: Uncategorized, message: "A required privilege is not held by the client." }

Symlink creation is a privileged operation (https://doc.rust-lang.org/stable/std/os/windows/fs/fn.symlink_file.html#limitations), it may be enabled on CI, but it's typically not enabled on user machines.

Standard library tests do not currently consider such failures fatal and treat the tests as ignored or passed, it would be better if run-make tests did the same thing.

jieyouxu · 2024-06-22T23:20:05Z

@petrochenkov thanks for the heads up. I think I will mark these symlink tests as //@ ignore-windows, because imo it would be lying (false sense of security) to say the test "passed" on Windows because symlink failed.

jieyouxu · 2024-06-23T00:35:21Z

Update: opened PR #126846 to ignore these tests on Windows.

rustbot assigned jieyouxu May 28, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 28, 2024

This comment has been minimized.

Sign in to view

jieyouxu reviewed May 28, 2024

View reviewed changes

src/tools/run-make-support/src/lib.rs Outdated Show resolved Hide resolved

tests/run-make/symlinked-rlib/rmake.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2024

Oneirical force-pushed the another-day-another-test branch from 58ac55a to 1e0a952 Compare May 29, 2024 15:57

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2024

This comment has been minimized.

Sign in to view

Oneirical force-pushed the another-day-another-test branch from afbdbbe to 2e08de0 Compare May 29, 2024 16:41

jieyouxu requested changes May 29, 2024

View reviewed changes

src/tools/run-make-support/src/lib.rs Outdated Show resolved Hide resolved

tests/run-make/symlinked-rlib/rmake.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2024

Oneirical force-pushed the another-day-another-test branch from 2e08de0 to 1b8d584 Compare May 29, 2024 17:05

Oneirical requested a review from jieyouxu May 29, 2024 17:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2024

jieyouxu approved these changes May 29, 2024

View reviewed changes

Oneirical added 3 commits June 12, 2024 09:44

port symlinked-extern to rmake

80408e0

port symlinked-rlib to rmake

59acd23

port symlinked-libraries to rmake

2ac5faa

Oneirical force-pushed the another-day-another-test branch from a94c002 to 2ac5faa Compare June 12, 2024 13:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2024

jieyouxu approved these changes Jun 12, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024

workingjubilee mentioned this pull request Jun 13, 2024

Rollup of 11 pull requests #126369

Closed

workingjubilee mentioned this pull request Jun 13, 2024

Rollup of 10 pull requests #126374

Merged

bors merged commit 1a6b1a1 into rust-lang:master Jun 13, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jun 13, 2024

Oneirical deleted the another-day-another-test branch June 13, 2024 13:41

jieyouxu mentioned this pull request Jun 23, 2024

Ignore run-make tests that use symlink on Windows and adjust symlink wrapper #126846

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format #125674

Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format #125674

Oneirical commented May 28, 2024 •

edited by jieyouxu

Loading

rustbot commented May 28, 2024

rustbot commented May 28, 2024

This comment has been minimized.

This comment has been minimized.

Oneirical commented May 28, 2024 •

edited

Loading

jieyouxu commented May 28, 2024

jieyouxu commented May 28, 2024

Oneirical commented May 29, 2024 •

edited

Loading

This comment has been minimized.

jieyouxu commented May 29, 2024

bors commented May 29, 2024

Oneirical commented Jun 12, 2024

jieyouxu commented Jun 12, 2024

jieyouxu commented Jun 12, 2024

bors commented Jun 12, 2024

bors commented Jun 13, 2024

Oneirical commented Jun 13, 2024

bors commented Jun 13, 2024

petrochenkov commented Jun 22, 2024

jieyouxu commented Jun 22, 2024 •

edited

Loading

jieyouxu commented Jun 23, 2024

Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format #125674

Rewrite symlinked-extern, symlinked-rlib and symlinked-libraries run-make tests in rmake.rs format #125674

Conversation

Oneirical commented May 28, 2024 • edited by jieyouxu Loading

rustbot commented May 28, 2024

rustbot commented May 28, 2024

This comment has been minimized.

This comment has been minimized.

Oneirical commented May 28, 2024 • edited Loading

jieyouxu commented May 28, 2024

jieyouxu commented May 28, 2024

Oneirical commented May 29, 2024 • edited Loading

This comment has been minimized.

jieyouxu commented May 29, 2024

bors commented May 29, 2024

Oneirical commented Jun 12, 2024

jieyouxu commented Jun 12, 2024

jieyouxu commented Jun 12, 2024

bors commented Jun 12, 2024

bors commented Jun 13, 2024

Oneirical commented Jun 13, 2024

bors commented Jun 13, 2024

petrochenkov commented Jun 22, 2024

jieyouxu commented Jun 22, 2024 • edited Loading

jieyouxu commented Jun 23, 2024

Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format #125674

Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format #125674

Oneirical commented May 28, 2024 •

edited by jieyouxu

Loading

Oneirical commented May 28, 2024 •

edited

Loading

Oneirical commented May 29, 2024 •

edited

Loading

jieyouxu commented Jun 22, 2024 •

edited

Loading