Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #125536

Closed
wants to merge 16 commits into from

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    e7772f2 View commit details
    Browse the repository at this point in the history
  2. fix typo

    Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
    RalfJung and workingjubilee authored May 19, 2024
    Configuration menu
    Copy the full SHA
    3c2d9c2 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    09c8e39 View commit details
    Browse the repository at this point in the history
  2. Stop using the avx512er and avx512pf x86 target features

    They are no longer supported by LLVM 19.
    
    Fixes rust-lang#125492
    zmodem committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3fe3157 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ebd9f35 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1af490d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    61aac55 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    f4b9ac6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    045f448 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125271 - RalfJung:posix_memalign, r=working…

    …jubilee
    
    use posix_memalign on almost all Unix targets
    
    Seems nice to be able to use a single common codepath for all of them. :) The `libc` crate says this symbol exists for all Unix targets. I did locally do check-builds to ensure this still builds, but I can't really test more than that.
    
    - For redox, I found indications posix_memalign really exists [here](https://gitlab.redox-os.org/redox-os/relibc/-/merge_requests/271)
    - For esp-idf, I found indications [here](playable-tech/esp-idf@c5b297a)
    - ~~For horizon and vita (these seem to be gaming console OSes? "Horizon OS" also has some hits for a Facebook product but that seems unrelated), they seem to be based on "newlib", where posix_memalign [seems to exist](https://sourceware.org/git/?p=newlib-cygwin.git;a=commitdiff;h=3ba2c39fb2a12cd7332ef16b1b3e3df994f7c6f5).~~ Turns out no, this 20-year-old standard POSIX function is unfortunately [not supported](rust-lang#125271 (comment)) here.
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    d65eeac View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125433 - surechen:fix_125189, r=Urgau

    A small diagnostic improvement for dropping_copy_types
    
    For a value `m`  which implements `Copy` trait, `drop(m);` does nothing.
    We now suggest user to ignore it by a abstract and general note: `let _ = ...`.
    I think we can give a clearer note here: `let _ = m;`
    
    fixes rust-lang#125189
    
    <!--
    If this PR is related to an unstable feature or an otherwise tracked effort,
    please link to the relevant tracking issue here. If you don't know of a related
    tracking issue or there are none, feel free to ignore this.
    
    This PR will get automatically assigned to a reviewer. In case you would like
    a specific user to review your work, you can assign it to them by using
    
        r​? <reviewer name>
    -->
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    b2509ee View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125498 - zmodem:avx512er, r=workingjubilee

    Stop using the avx512er and avx512pf x86 target features
    
    They are no longer supported by LLVM 19.
    
    Fixes rust-lang#125492
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    3e8b60a View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125510 - lcnr:change-proof-trees-to-be-shal…

    …low, r=compiler-errors
    
    remove proof tree formatting, make em shallow
    
    Debugging via tracing `RUSTC_LOG=rustc_trait_selection::solve=debug` is now imo slightly more readable then the actual proof tree formatter. Removing everything that's not needed for the `analyse` visitor allows us to remove a bunch of code.
    
    I personally believe that we should continue to use tracing over proof trees for debugging:
    - it eagerly prints, allowing us to debug ICEs
    - the proof tree builder ends up going out of sync with the actual runtime behavior, which is confusing
    - using shallow proof trees is a lot more performant as we frequently do not recurse into all nested goals when using an analyse visitor
    - this allows us to clean up the implementation and remove some code
    
    r? ``@compiler-errors``
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    b1efe2d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125513 - compiler-errors:impossible-drop, r…

    …=jackh726
    
    Don't eagerly monomorphize drop for types that are impossible to instantiate
    
    Self-explanatory title I think
    
    Fixes rust-lang#125509
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    b517691 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125514 - compiler-errors:builtin-index, r=lcnr

    Structurally resolve before `builtin_index` in EUV
    
    r? lcnr
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    38b4c90 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#125527 - programmerjake:patch-2, r=workingj…

    …ubilee
    
    Add manual Sync impl for ReentrantLockGuard
    
    Fixes: rust-lang#125526
    Tracking Issue: rust-lang#121440
    
    this impl is even shown in the summary in the tracking issue, but apparently was forgotten in the actual implementation
    workingjubilee authored May 25, 2024
    Configuration menu
    Copy the full SHA
    8743112 View commit details
    Browse the repository at this point in the history