Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] Delay the construction of early lint diag structs #125410

Merged
merged 4 commits into from
May 27, 2024
Merged

[perf] Delay the construction of early lint diag structs #125410

merged 4 commits into from
May 27, 2024

Commits on May 23, 2024

  1. Slightly clean up some lint infra code 

    * inline `LintBuffer::add_lint`, it only had a single use
* update a lint infra example code snippet
  * it used the wrong API (the snippet isn't tested)
  * presumably the arguments were updated from builder to diag struct style
    at some point without updating the method
    @fmease
    fmease committed May 23, 2024
    Configuration menu
    Copy the full SHA
    366ef95 View commit details
    Browse the repository at this point in the history

  2. Remove LintDiagnostic::msg 

    * instead simply set the primary message inside the lint decorator functions
* it used to be this way before [#]101986 which introduced `msg` to prevent
  good path delayed bugs (which no longer exist) from firing under certain
  circumstances when lints were suppressed / silenced
* this is no longer necessary for various reasons I presume
* it shaves off complexity and makes further changes easier to implement
    @fmease
    fmease committed May 23, 2024
    Configuration menu
    Copy the full SHA
    06bc4fc View commit details
    Browse the repository at this point in the history

  3. Remove DelayDm 

    With the removal of `LintDiagnostic::msg` / the `msg` param from
lint diag APIs, primary messages for lint diags are always constructed
lazily inside decorator fns rendering this wrapper type unused / useless.
    @fmease
    fmease committed May 23, 2024
    Configuration menu
    Copy the full SHA
    9f67c50 View commit details
    Browse the repository at this point in the history

  4. Delay the construction of early lint diag structs 

    Fixes a slew of perf regressions.
    @fmease
    fmease committed May 23, 2024
    Configuration menu
    Copy the full SHA
    37bf2d2 View commit details
    Browse the repository at this point in the history