Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[inline] to float Debug fallback used by cfg(no_fp_fmt_parse) #125252

Merged
merged 1 commit into from
May 19, 2024
Merged

Add #[inline] to float Debug fallback used by cfg(no_fp_fmt_parse) #125252

merged 1 commit into from
May 19, 2024

Conversation

beetrees
Copy link
Contributor

Fixes #125229.

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2024
@beetrees beetrees mentioned this pull request May 18, 2024
Closed
@ojeda ojeda mentioned this pull request May 18, 2024
Open
50 tasks
tgross35
tgross35 approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about what I expected. Thanks for the fix.

@ojeda
Copy link
Contributor

ojeda commented May 19, 2024

Thanks @beetrees!

This should eventually be backported to beta, right?

@joboet
Copy link
Member

joboet commented May 19, 2024

Looks fine!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 19, 2024

📌 Commit 827711d has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@joboet joboet added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 19, 2024
@compiler-errors compiler-errors mentioned this pull request May 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2024
@bors
Auto merge of rust-lang#125280 - compiler-errors:rollup-401itda, r=co…
6982935 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123709 (Update documentation related to the recent cmd.exe fix)
 - rust-lang#124304 (revise the interpretation of ReadDir for HermitOS)
 - rust-lang#124708 (Actually use the `#[do_not_recommend]` attribute if present)
 - rust-lang#125252 (Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)`)
 - rust-lang#125261 (crashes: add more)
 - rust-lang#125270 (Followup fixes from rust-lang#123344)
 - rust-lang#125275 (Migrate `run-make/rustdoc-scrape-examples-test` to new `rmake.rs`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit edace32 into rust-lang:master May 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2024
@rust-timer
Unrolled build for rust-lang#125252
15e3bc5 
Rollup merge of rust-lang#125252 - beetrees:patch-1, r=joboet

Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)`

Fixes rust-lang#125229.
@Amanieu Amanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 22, 2024
@cuviper cuviper mentioned this pull request May 25, 2024
Merged
@cuviper cuviper modified the milestones: 1.80.0, 1.79.0 May 25, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125529 - cuviper:beta-next, r=cuviper
2423248 
[beta] backports

- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)` rust-lang#125252
- Add v0 symbol mangling for `f16` and `f128` rust-lang#123816
- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability rust-lang#125214
- Update to LLVM 18.1.6 rust-lang#125288

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125529 - cuviper:beta-next, r=cuviper
d9e85b5 
[beta] backports

- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)` rust-lang#125252
- Add v0 symbol mangling for `f16` and `f128` rust-lang#123816
- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability rust-lang#125214
- Update to LLVM 18.1.6 rust-lang#125288

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@joboet joboet

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

f16/f128 fallback code is not getting inlined
8 participants
@beetrees @rustbot @ojeda @joboet @bors @tgross35 @cuviper @Amanieu