-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite select (in the new solver) to use a ProofTreeVisitor
#124529
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
r? lcnr |
b7b5763
to
be1d5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after nits
☔ The latest upstream changes (presumably #124558) made this pull request unmergeable. Please resolve the merge conflicts. |
32aec4d
to
6760051
Compare
@bors r=lcnr rollup (new solver only) |
Rewrite select (in the new solver) to use a `ProofTreeVisitor` We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves. Based on rust-lang#124415
This comment has been minimized.
This comment has been minimized.
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#124529 (Rewrite select (in the new solver) to use a `ProofTreeVisitor`) - rust-lang#124542 (Add diagnostic item for `std::iter::Iterator::enumerate`) - rust-lang#124566 (fix `NormalizesTo` proof tree issue) r? `@ghost` `@rustbot` modify labels: rollup
@bors r- ^ |
@bors r=lcnr |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f92d49b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.001s -> 674.637s (0.09%) |
We can use a proof tree visitor rather than collecting and recomputing all the nested goals ourselves.
Based on #124415