Keep the LIB env var in the compiler-builtins test #124378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in run-make tests. cc @jieyouxu |
jieyouxu
approved these changes
Apr 25, 2024
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#124076 (Stablise io_error_downcast) - rust-lang#124378 (Keep the LIB env var in the compiler-builtins test) - rust-lang#124379 (Remove special-casing for `SimplifiedType` for next solver) - rust-lang#124381 (Renamed `DerivedObligation` to `WellFormedDeriveObligation`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
Rollup merge of rust-lang#124378 - dpaoliello:keeplib, r=jieyouxu Keep the LIB env var in the compiler-builtins test The `tests/run-make/compiler-builtins` test was failing for me with Visual Studio 2022, complaining that it couldn't find `kernel32.lib`. For whatever reason, with VS 2022 we need to keep the `LIB` environment variable when invoking Cargo so that the linker can find the Windows SDK libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tests/run-make/compiler-builtinstest was failing for me with Visual Studio 2022, complaining that it couldn't findkernel32.lib.For whatever reason, with VS 2022 we need to keep the
LIBenvironment variable when invoking Cargo so that the linker can find the Windows SDK libs.