Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: unnecessary clone during lower generics args #124224

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 21, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

HIR ty lowering was modified

cc @fmease

@fmease
Copy link
Member

fmease commented Apr 21, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 21, 2024

📌 Commit 2d5a226 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2024
@fmease
Copy link
Member

fmease commented Apr 21, 2024

Ha, I've actually been aware of this unnecessary clone haha. I have a patch locally that cleans that up, too, among a bunch of other cleanups.

Thanks!

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 21, 2024
cleanup: unnecessary clone during lower generics args
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 21, 2024
cleanup: unnecessary clone during lower generics args
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123840 (Add an intrinsic for `ptr::from_raw_parts(_mut)`)
 - rust-lang#124224 (cleanup: unnecessary clone during lower generics args)
 - rust-lang#124229 (Add gnullvm targets to manifest)
 - rust-lang#124231 (remove from reviewers)
 - rust-lang#124235 (Move some tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cd92422 into rust-lang:master Apr 21, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
Rollup merge of rust-lang#124224 - bvanjoi:cleanup, r=fmease

cleanup: unnecessary clone during lower generics args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants