Call the panic hook for non-unwind panics in proc-macros #123825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saethlin
added
the
beta-nominated
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
report-nounwind-panics
branch
from
036e538
to
d8dc28b
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123204 (rustdoc: point at span in `include_str!`-ed md file) - rust-lang#123223 (Fix invalid silencing of parsing error) - rust-lang#123249 (do not add prolog for variadic naked functions) - rust-lang#123825 (Call the panic hook for non-unwind panics in proc-macros) - rust-lang#123833 (Update stdarch submodule) - rust-lang#123841 (Improve diagnostic by suggesting to remove visibility qualifier) - rust-lang#123849 (Update E0384.md) - rust-lang#123852 (fix typo in library/std/src/lib.rs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
Rollup merge of rust-lang#123825 - saethlin:report-nounwind-panics, r=petrochenkov Call the panic hook for non-unwind panics in proc-macros As I suggested in rust-lang#123286 (comment). If a proc macro causes a non-unwinding panic, `proc_macro` isn't able to catch the unwind and report the panic as a compile error by passing control back to the compiler. Our only chance to produce any diagnostic is the panic hook, so we should call it. This scenario has already existed, but has become a lot more interesting now that we're adding more UB-detecting panics to the standard library, and such panics do not unwind.
apiraino
added
the
T-compiler
rustbot
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
[beta] backports - Silence `unused_imports` lint for redundant imports rust-lang#123744 - Call the panic hook for non-unwind panics in proc-macros rust-lang#123825 - rustdoc: check redundant explicit links with correct itemid rust-lang#123905 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
[beta] backports - Silence `unused_imports` lint for redundant imports rust-lang#123744 - Call the panic hook for non-unwind panics in proc-macros rust-lang#123825 - rustdoc: check redundant explicit links with correct itemid rust-lang#123905 - disable two debuginfo tests under gdb 15 rust-lang#123963 r? cuviper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I suggested in #123286 (comment).
If a proc macro causes a non-unwinding panic,
proc_macroisn't able to catch the unwind and report the panic as a compile error by passing control back to the compiler. Our only chance to produce any diagnostic is the panic hook, so we should call it.This scenario has already existed, but has become a lot more interesting now that we're adding more UB-detecting panics to the standard library, and such panics do not unwind.