-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #123823
Rollup of 8 pull requests #123823
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2e5ee4 - Browse repository at this point
Copy the full SHA c2e5ee4View commit details
Commits on Apr 6, 2024
-
Account for trait/impl difference when suggesting changing argument f…
…rom ref to mut ref Do not ICE when encountering a lifetime error involving an argument with an immutable reference of a method that differs from the trait definition. Fix rust-lang#123414.
Configuration menu - View commit details
-
Copy full SHA for 731c0e5 - Browse repository at this point
Copy the full SHA 731c0e5View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1972c0 - Browse repository at this point
Copy the full SHA e1972c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d7c83 - Browse repository at this point
Copy the full SHA 68d7c83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91fe6f9 - Browse repository at this point
Copy the full SHA 91fe6f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 510bfc2 - Browse repository at this point
Copy the full SHA 510bfc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0db2a40 - Browse repository at this point
Copy the full SHA 0db2a40View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b3600 - Browse repository at this point
Copy the full SHA d5b3600View commit details -
Rollup merge of rust-lang#122882 - Zoxc:panic-output-panic, r=Amanieu
Avoid a panic in `set_output_capture` in the default panic handler This avoid a panic in the default panic handler by not using `set_output_capture` as `OUTPUT_CAPTURE.with` may panic once `OUTPUT_CAPTURE` is dropped. A new non-panicking `try_set_output_capture` variant of `set_output_capture` is added for use in the default panic handler.
Configuration menu - View commit details
-
Copy full SHA for 1e99af5 - Browse repository at this point
Copy the full SHA 1e99af5View commit details -
Rollup merge of rust-lang#123523 - estebank:issue-123414, r=BoxyUwU
Account for trait/impl difference when suggesting changing argument from ref to mut ref Do not ICE when encountering a lifetime error involving an argument with an immutable reference of a method that differs from the trait definition. Fix rust-lang#123414.
Configuration menu - View commit details
-
Copy full SHA for ec91d71 - Browse repository at this point
Copy the full SHA ec91d71View commit details -
Rollup merge of rust-lang#123744 - compiler-errors:redundant-due-to-g…
…lob, r=petrochenkov Silence `unused_imports` for redundant imports Quick fix for rust-lang#121708 (comment) r? `@petrochenkov` cc `@joshtriplett` I think this is right, would like confirmation. I also think it's weird that we're using `=` to assign to `is_redundant` but using `per_ns` for the actual spans. Seems like this could be weirdly order dependent, but that's unrelated to this change.
Configuration menu - View commit details
-
Copy full SHA for da75aaf - Browse repository at this point
Copy the full SHA da75aafView commit details -
Rollup merge of rust-lang#123784 - GuillaumeGomez:replace-document-wr…
…ite, r=notriddle Replace `document.write` with `document.head.insertAdjacent` From [this comment](https://github.com/rust-lang/rust/pull/123706/files#r1559864981), using `document.write` is strongly discouraged (explained on [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Document/write)). I think in this case it was mostly ok but better be on the safe side. r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for 0ab8cc1 - Browse repository at this point
Copy the full SHA 0ab8cc1View commit details -
Rollup merge of rust-lang#123798 - tniessen:patch-1, r=workingjubilee
Avoid invalid socket address in length calculation This has no effect on the lengths of these constants, but since the IP address portion of the socket addresses was intentionally chosen to be the largest valid value, it seems appropriate to also use the largest valid value for the other components (as opposed to invalid values exceeding the possible ranges).
Configuration menu - View commit details
-
Copy full SHA for f361026 - Browse repository at this point
Copy the full SHA f361026View commit details -
Rollup merge of rust-lang#123804 - compiler-errors:podcrab-fix, r=jie…
…youxu Stop using `HirId` for fn-like parents since closures are not `OwnerNode`s This is a minimal fix for rust-lang#123273. I'm overall pretty disappointed w/ the state of this code; although it's "just diagnostics", it still should be maintainable and understandable and neither of those are true. I believe this code really needs some major overhauling before anything more should be added to it, because there are subtle invariants that are being exercised and subsequently broken all over the place, and I don't think we should just paper over them (e.g.) by delaying bugs or things like that. I wouldn't be surprised if fixing up this code would also yield better diagnostics.
Configuration menu - View commit details
-
Copy full SHA for 17a8ee6 - Browse repository at this point
Copy the full SHA 17a8ee6View commit details -
Rollup merge of rust-lang#123806 - joboet:advanced_overflow, r=Amanieu
Panic on overflow in `BorrowedCursor::advance` Passing `usize::MAX` to `advance` clearly isn't correct, but the current assertion fails to detect this when overflow checks are disabled. This isn't unsound, but should probably be fixed regardless.
Configuration menu - View commit details
-
Copy full SHA for d8ae975 - Browse repository at this point
Copy the full SHA d8ae975View commit details -
Rollup merge of rust-lang#123820 - bash:mailmap, r=workingjubilee
Add my former address to .mailmap
Configuration menu - View commit details
-
Copy full SHA for d2e9ec7 - Browse repository at this point
Copy the full SHA d2e9ec7View commit details