Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More translatable diagnostics #123822

Closed
wants to merge 12 commits into from
Closed

More translatable diagnostics #123822

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
78fba85
Fix diagnostics to invalid metavar exprs
Xiretza Aug 17, 2024
1a09dd4
Fix typo in meta-var expr diagnostics
Xiretza Aug 17, 2024
3ae0ae9
rustc_expand: add FIXMEs for translation
Xiretza Apr 14, 2024
da547b7
Factor out ICU4X list formatter creation
Xiretza Aug 18, 2024
0a7d3da
rustc_baked_icu_data: regenerate
Xiretza Aug 19, 2024
bbb3759
Add StrListSepByOr
Xiretza Aug 18, 2024
7ff2696
rustc_session: turn feature gate subdiagnostic into struct
Xiretza Apr 11, 2024
332ebed
Expose FeatureGateSubdiagnostic struct instead of applying it opaquely
Xiretza Apr 11, 2024
9d9ad48
impl IntoDiagArg for TokenTree
Xiretza Aug 17, 2024
bce7c46
impl IntoDiagArg for NonterminalKind
Xiretza Aug 19, 2024
e7c1fd3
Make more diagnostics in rustc_expand translatable
Xiretza Apr 11, 2024
bd98f08
rustc_expand: make mbe translatable
Xiretza Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler/rustc_errors/src/diagnostic_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use std::num::ParseIntError;
use std::path::{Path, PathBuf};
use std::process::ExitStatus;

use rustc_ast::token::NonterminalKind;
use rustc_ast_pretty::pprust;
use rustc_macros::Subdiagnostic;
use rustc_span::edition::Edition;
Expand Down Expand Up @@ -304,6 +305,12 @@ impl IntoDiagArg for hir::def::Namespace {
}
}

impl IntoDiagArg for NonterminalKind {
fn into_diag_arg(self) -> DiagArgValue {
DiagArgValue::Str(Cow::from(self.to_string()))
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put this change in the commit where you actually use it?

#[derive(Clone)]
pub struct DiagSymbolList<S = Symbol>(Vec<S>);

Expand Down