Factor some common io::Error constants

[a1phyr]

No description provided.

[rustbot]

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[cuviper]

That's a nice cleanup, thanks!

@bors r+

[bors]

📌 Commit 05e7396 has been approved by cuviper

It is now in the queue for this repository.

[tgross35]

This looks to have failed in the rollup, https://github.com/rust-lang-ci/rust/actions/runs/8637707189/job/23680527190#step:27:3291

   error: associated constant `ZERO_TIMEOUT` is never used
    --> library/std/src/io/error.rs:93:22
     |
  79 | impl Error {
     | ---------- associated constant in this implementation
  ...
  93 |     pub(crate) const ZERO_TIMEOUT: Self =
     |                      ^^^^^^^^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(dead_code)]`
  
  [RUSTC-TIMING] std test:false 2.337
  warning: `std` (lib) generated 1 warning
  error: could not compile `std` (lib) due to 1 previous error; 1 warning emitted

Probably need to gate some of these errors to specific platforms

[fmease]

@bors r-

[fmease]

@bors rollup=iffy exercises #[cfg]-heavy code

[cuviper]

@bors r+

[bors]

📌 Commit 9c64068 has been approved by cuviper

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9c64068 with merge aa6a697...

[bors]

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing aa6a697 to master...

[rust-timer]

Finished benchmarking commit (aa6a697): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

• rustc

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.8%, -0.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.8%, -0.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.4%	[5.2%, 7.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-4.4%, -4.4%]	1
All ❌✅ (primary)	6.4%	[5.2%, 7.5%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 1.1%]	11
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-1.0%, -0.0%]	18
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-1.0%, 1.1%]	29

Bootstrap: missing data
Artifact size: 315.97 MiB -> 315.97 MiB (-0.00%)