rustdoc: reduce per-page HTML overhead #123706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
This cuts the HTML overhead for a page by about 1KiB, significantly reducing the overall size of the docs bundle.
According to <https://caniuse.com/?search=svg%20favicon>, SVG favicons are supported in everything but Safari. When I actually try it in Safari, it's downloading all three favicons, and nothing looks different when I disable the 16x16 one. <https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>, which is linked from caniuse above, recommends an ico. However, the reason they recommend it is the apps that only support /favicon.ico exactly, and rustdoc can't assume it will be installed to the site root, so it's unfortunately up to the webmaster to make sure it's set up.
notriddle
force-pushed
the
notriddle/html-cleanup
branch
from
b47ffc2 to
87faa21
Compare
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in GUI tests. |
GuillaumeGomez
approved these changes
Apr 10, 2024
|
That's better indeed, thanks! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#118391 (Add `REDUNDANT_LIFETIMES` lint to detect lifetimes which are semantically redundant) - rust-lang#123534 (Windows: set main thread name without re-encoding) - rust-lang#123659 (Add support to intrinsics fallback body) - rust-lang#123689 (Add const generics support for pattern types) - rust-lang#123701 (Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place) - rust-lang#123702 (Further cleanup cfgs in the UI test suite) - rust-lang#123706 (rustdoc: reduce per-page HTML overhead) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
Rollup merge of rust-lang#123706 - notriddle:notriddle/html-cleanup, r=GuillaumeGomez rustdoc: reduce per-page HTML overhead r? `@GuillaumeGomez`
bjorn3
reviewed
Apr 10, 2024
| `)</script> {# #} | ||
| <script>if(window.location.protocol!=="file:") {# Hack to skip preloading fonts locally - see #98769 #} | ||
| for(f of "{{files.source_serif_4_regular}},{{files.fira_sans_regular}},{{files.fira_sans_medium}},{{files.source_code_pro_regular}},{{files.source_code_pro_semibold}}".split(",")) {# #} | ||
| document.write(`<link rel="preload" as="font" type="font/woff2" crossorigin href="{{static_root_path|safe}}${f}">`) {# #} |
There was a problem hiding this comment.
Using document.write breaks speculative parsing of the html afaik.
There was a problem hiding this comment.
Good to know! I'll send an improvement.
|
Wow. Congrats again @notriddle! |
Merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2024
…n, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2024
…n, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? ``@notriddle``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
Rollup merge of rust-lang#124041 - GuillaumeGomez:fix-copy-path-button, r=notriddle Fix copy path button Currently, on all nightly docs, clicking on the "copy path" button triggers a JS error. It's because changes in rust-lang#123706 forgot to update the JS (it contained an image before but not anymore). I had to make some small changes in the CSS to fix the display when the button was clicked as well. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 28, 2024
…, r=notriddle Inline more svg images into CSS Follow-up of rust-lang#123706. r? `@notriddle`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2024
Rollup merge of rust-lang#123734 - GuillaumeGomez:inline-svg-into-css, r=notriddle Inline more svg images into CSS Follow-up of rust-lang#123706. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez