Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: slightly clean up the synthesis of blanket impls #123647

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Apr 8, 2024

Small follow-up to #123340 as promised in #123340 (comment). No functional changes whatsoever.

  • inline the over-engineered “type namespace” (struct) BlanketImplFinder just like I did with AutoTraitFinder in rustdoc: heavily simplify the synthesis of auto trait impls #123340
  • use the new synthesize_* terminology over the old nondescript / misleading get_* one
  • inline a use super::*; (not super modular, lead to clean/mod.rs (!) accumulating cruft)
  • use tracing properly

r? GuillaumeGomez or rustdoc

@fmease fmease changed the title Slightly clean up the synthesis of blanket impls rustdoc: lightly clean up the synthesis of blanket impls Apr 8, 2024
@fmease fmease force-pushed the rustdoc-clean-up-blanket-impls-synth branch from f3702ce to 31a69d9 Compare April 8, 2024 20:56
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 8, 2024
@fmease fmease added C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2024
@fmease fmease changed the title rustdoc: lightly clean up the synthesis of blanket impls rustdoc: slightly clean up the synthesis of blanket impls Apr 8, 2024
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@camelid
Copy link
Member

camelid commented Apr 9, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 9, 2024

📌 Commit 31a69d9 has been approved by camelid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122768 (Use the more informative generic type inference failure error on method calls on raw pointers)
 - rust-lang#123620 (sanitizers: Create the rustc_sanitizers crate)
 - rust-lang#123624 ([rustdoc] [GUI tests] Make theme switching closer to reality)
 - rust-lang#123636 (Update books)
 - rust-lang#123647 (rustdoc: slightly clean up the synthesis of blanket impls)
 - rust-lang#123648 (Avoid ICEing without the pattern_types feature gate)
 - rust-lang#123649 (KCFI: Use legal charset in shim encoding)
 - rust-lang#123652 (Fix UI tests with dist-vendored dependencies)
 - rust-lang#123655 (Remove unimplemented!() from BinOp::ty() function)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f3b4412 into rust-lang:master Apr 9, 2024
18 of 22 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
Rollup merge of rust-lang#123647 - fmease:rustdoc-clean-up-blanket-impls-synth, r=camelid

rustdoc: slightly clean up the synthesis of blanket impls

Small follow-up to rust-lang#123340 as promised in rust-lang#123340 (comment). No functional changes whatsoever.

* inline the over-engineered “type namespace” (struct) `BlanketImplFinder` just like I did with `AutoTraitFinder` in rust-lang#123340
* use the new `synthesize_*` terminology over the old nondescript / misleading `get_*` one
* inline a `use super::*;` (not super modular, lead to `clean/mod.rs` (!) accumulating cruft)
* use `tracing` properly

r? GuillaumeGomez or rustdoc
@fmease fmease deleted the rustdoc-clean-up-blanket-impls-synth branch April 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants