Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: PoC for derive(SmartPointer) #123472

Closed
wants to merge 1 commit into from
Closed

WIP: PoC for derive(SmartPointer) #123472

wants to merge 1 commit into from

Conversation

wedsonaf
Copy link
Contributor

@wedsonaf wedsonaf commented Apr 4, 2024

Tracking issue: #123430

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 4, 2024
@compiler-errors compiler-errors self-assigned this Apr 4, 2024
@traviscross traviscross added the F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation label Apr 4, 2024
@compiler-errors
Copy link
Member

Marking this as waiting-on-author since it's in draft mode

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2024
@wedsonaf wedsonaf marked this pull request as ready for review April 10, 2024 04:46
@bors
Copy link
Contributor

bors commented Apr 11, 2024

☔ The latest upstream changes (presumably #123762) made this pull request unmergeable. Please resolve the merge conflicts.

@wedsonaf
Copy link
Contributor Author

Rebased.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2024
compiler-errors
compiler-errors reviewed Apr 12, 2024
View reviewed changes
library/core/src/lib.rs
#[unstable(feature = "derive_smart_pointer", issue = "123430")]
pub macro SmartPointer($item:item) {
/* compiler built-in */
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This macro definitely should not go into the root module of the core crate. Please look at other derive macros to see what the precedent is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2024
@pnkfelix
Copy link
Member

pnkfelix commented Apr 12, 2024 •
edited
Loading

A general comment: The tracking issue #123430 does not have any links to what this thing is supposed to do. I do not know how to evaluate this code without having an idea of what it is supposed to be used for.

Is there someone from the T-lang team who has agreed to shepherd this experimental feature? or a link to perhaps a zulip topic or other linkable discussion thread that I could use to try to extract a rough idea of what this is for?

@ojeda ojeda mentioned this pull request Apr 12, 2024
Open
89 tasks
@ojeda
Copy link
Contributor

ojeda commented Apr 12, 2024 •
edited
Loading

I have a couple links in Rust for Linux's #2:

@bors
Copy link
Contributor

bors commented Apr 27, 2024

☔ The latest upstream changes (presumably #124424) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@wedsonaf any updates on this? thanks

@ojeda
Copy link
Contributor

ojeda commented May 6, 2024

Linking the RFC PR too: rust-lang/rfcs#3621.

@Dylan-DPC Dylan-DPC added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label May 7, 2024
@dingxiangfei2009 dingxiangfei2009 mentioned this pull request May 13, 2024
Merged
@dingxiangfei2009 dingxiangfei2009 mentioned this pull request May 26, 2024
Merged
@traviscross traviscross mentioned this pull request May 27, 2024
Open
6 tasks
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 24, 2024
@compiler-errors
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr,…
ed460d2 
… r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2024
@rust-timer
Unrolled build for rust-lang#125575
8a6bce8 
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
@Darksonn
Copy link
Contributor

Darksonn commented Aug 6, 2024

This should probably be closed as superseded by #125575.

@lqd lqd closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@pnkfelix pnkfelix pnkfelix left review comments

Assignees

@pnkfelix pnkfelix

@compiler-errors compiler-errors

Labels
F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@wedsonaf @rustbot @compiler-errors @bors @pnkfelix @ojeda @Dylan-DPC @Darksonn @lqd @traviscross