Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle inlining of doc hidden foreign items #123459

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Correctly handle inlining of doc hidden foreign items #123459

merged 3 commits into from
Apr 11, 2024

Commits on Apr 4, 2024

  1. Improve code a bit

    @GuillaumeGomez
    GuillaumeGomez committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    20ed971 View commit details
    Browse the repository at this point in the history

  2. In case a foreign item has doc(hidden) attribute, we simply merged … 

    …its attributes

with the re-export's, making it being removed once in the `strip_hidden` pass.

The solution was to use the same as for local reexported items: merge attributes,
but not some of them (like `doc(hidden)`).
    @GuillaumeGomez
    GuillaumeGomez committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0ee34e1 View commit details
    Browse the repository at this point in the history

  3. Add regression test for rust-lang#123435

    @GuillaumeGomez
    GuillaumeGomez committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5a0be6f View commit details
    Browse the repository at this point in the history