Add more comments to the bootstrap code that handles tests/coverage
#122982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
onur-ozkan
reviewed
Mar 24, 2024
| @@ -1319,6 +1319,7 @@ macro_rules! coverage_test_alias { | |||
| } | |||
|
|
|||
| fn run(self, builder: &Builder<'_>) { | |||
| // Actually running the tests goes through a common helper method. | |||
There was a problem hiding this comment.
This comment can be improved I think. It doesn't say enough about the context.
There was a problem hiding this comment.
Hmm, as think about how to explain this better, I’m realising that going through Coverage is unnecessarily complicated anyway.
If I change run_unified_suite to be a top-level helper function (with a better name), it should be easier to write a good comment. I’ll try it out tomorrow and see how it looks.
Zalathar
force-pushed
the
bootstrap-coverage-docs
branch
2 times, most recently
from
633ca8a to
b8834fa
Compare
Zalathar
force-pushed
the
bootstrap-coverage-docs
branch
from
b8834fa to
1bbab71
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#122858 (Tweak `parse_dot_suffix_expr`) - rust-lang#122982 (Add more comments to the bootstrap code that handles `tests/coverage`) - rust-lang#122990 (Clarify transmute example) - rust-lang#122995 (Clean up unnecessary headers/flags in coverage mir-opt tests) - rust-lang#123003 (CFI: Handle dyn with no principal) - rust-lang#123005 (CFI: Support complex receivers) - rust-lang#123020 (Temporarily remove nnethercote from the review rotation.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2024
Rollup merge of rust-lang#122982 - Zalathar:bootstrap-coverage-docs, r=onur-ozkan Add more comments to the bootstrap code that handles `tests/coverage` At the bootstrap level, coverage tests are a bit more complicated than other test suites, because we want to run the same set of test files in multiple different modes, in a way that's convenient and flexible when invoked manually. This PR adds a few more comments to explain what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the bootstrap level, coverage tests are a bit more complicated than other test suites, because we want to run the same set of test files in multiple different modes, in a way that's convenient and flexible when invoked manually.
This PR adds a few more comments to explain what's going on.