Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove repetitive words #122368

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore: remove repetitive words #122368

merged 1 commit into from
Mar 14, 2024

Conversation

pavedroad
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 12, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Mar 12, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 12, 2024

📌 Commit 18cb318 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@oli-obk oli-obk assigned oli-obk and unassigned estebank Mar 12, 2024
@pavedroad
chore: remove repetitive words
6b082b5 
Signed-off-by: pavedroad <qcqs@outlook.com>

chore: remove repetitive words

Signed-off-by: pavedroad <qcqs@outlook.com>
@pavedroad
Copy link
Contributor Author

Modified.

Please review again.

lukas-code
lukas-code approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@lukas-code lukas-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have permission to merge.

@oli-obk can you r+ it again?

@lukas-code
Copy link
Member

lukas-code commented Mar 14, 2024 •
edited
Loading

@rustbot label -S-waiting-on-bors +S-waiting-on-review

@bors
Copy link
Contributor

bors commented Mar 14, 2024

@lukas-code: 🔑 Insufficient privileges: Not in reviewers

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Mar 14, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2024

📌 Commit 6b082b5 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@bors
Auto merge of rust-lang#122497 - matthiaskrgr:rollup-pg9ux4r, r=matth…
30f74ff 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#119029 (Avoid closing invalid handles)
 - rust-lang#122238 (Document some builtin impls in the next solver)
 - rust-lang#122247 (rustdoc-search: depth limit `T<U>` -> `U` unboxing)
 - rust-lang#122287 (add test ensuring simd codegen checks don't run when a static assertion failed)
 - rust-lang#122368 (chore: remove repetitive words)
 - rust-lang#122397 (Various cleanups around the const eval query providers)
 - rust-lang#122406 (Fix WF for `AsyncFnKindHelper` in new trait solver)
 - rust-lang#122477 (Change some attribute to only_local)
 - rust-lang#122482 (Ungate the `UNKNOWN_OR_MALFORMED_DIAGNOSTIC_ATTRIBUTES` lint)
 - rust-lang#122490 (Update build instructions for OpenHarmony)

Failed merges:

 - rust-lang#122471 (preserve span when evaluating mir::ConstOperand)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1dce191 into rust-lang:master Mar 14, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2024
@rust-timer
Unrolled build for rust-lang#122368
c586af1 
Rollup merge of rust-lang#122368 - pavedroad:master, r=oli-obk

chore: remove repetitive words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-code lukas-code lukas-code approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pavedroad @rustbot @oli-obk @bors @lukas-code @estebank