Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #122338

Merged
merged 50 commits into from
Mar 11, 2024
Merged

Rollup of 15 pull requests #122338

merged 50 commits into from
Mar 11, 2024

Conversation

workingjubilee
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

WaffleLapkin and others added 30 commits February 14, 2024 23:43
This clarifies that we're adding an "entry point", not just adding an "entry"
of some kind.
This allows us to use real field names instead of tuple element numbers.

Renaming `previous_drops` to `existing_drops_map` clarifies that "previous" was
unrelated to drop order.
Like field offsets, these are always constant.
The `sig_dfl` variant of the attribute is the most likely variant to be
stabilized first, and thus to become the "most allowed" variant of the
attribute. Because of this, it is the most appropriate variant to use in
syntax tests, because even if the most allowed variant is used, the
compiler shall still emit errors if it e.g. is used in the wrong places.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 11, 2024
@workingjubilee
Copy link
Member Author

@bors r+ rollup=never p=15

@bors
Copy link
Contributor

bors commented Mar 11, 2024

📌 Commit 7fa6fa4 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2024
@bors
Copy link
Contributor

bors commented Mar 11, 2024

⌛ Testing commit 7fa6fa4 with merge 6554a56...

@workingjubilee
Copy link
Member Author

🧿 🧿 🧿 🧿 🧿 🧿 🧿
🧿 🧿 🧿 🧿 🧿 🧿 🧿 🧿
🧿 🧿 🧿 🧿 🧿 🧿

@bors
Copy link
Contributor

bors commented Mar 11, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 6554a56 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2024
@bors bors merged commit 6554a56 into rust-lang:master Mar 11, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 11, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#116791 Allow codegen backends to opt-out of parallel codegen a89ef7b52f5412da5f4a6d1c335cf683358f4c52 (link)
#116793 Allow targets to override default codegen backend 6c910a961d3975c09caad98b4a3cf17056e7f85b (link)
#117458 LLVM Bitcode Linker: A self contained linker for nvptx and … 4a922e7cb31f076292c369cf8393e53fa8fbcc91 (link)
#119385 Fix type resolution of associated const equality bounds (ta… 64fcfca30418c3aae9578b5eaa7959efcfca651a (link)
#121438 std support for wasm32 panic=unwind 08711d54d5557a4e799f4103b6c5c987398c8296 (link)
#121893 Add tests (and a bit of cleanup) for interior mut handling … 0a3d279358a8c1566b8c40613e2d52d2be64174b (link)
#122080 Clarity improvements to DropTree e36d64068edc0c1f872a76fbe0ec849ae633c2e6 (link)
#122152 Improve diagnostics for parenthesized type arguments c656bd646152d9301e25681a3df4ae4a1185366d (link)
#122166 Remove the unused field_remapping field from `TypeLowerin… febd6c8ca4c1459d6cf48eea1179311ba9a64d7d (link)
#122249 interpret: do not call machine read hooks during validation c39ad27214a40bd2ad8c235f90ede77c494c6402 (link)
#122299 Store backtrace for must_produce_diag ba8809b89587bc460571d001527f63595496dce0 (link)
#122318 Revision-related tweaks for next-solver tests 189cbe2d88be1be0352fff66d485e98beb46350a (link)
#122320 Use ptradd for vtable indexing 2b188cc7cdf52ad7ac653006cce8ce7395519d5c (link)
#122328 unix_sigpipe: Replace inherit with sig_dfl in syntax te… e331cbe51ef4c5922e295ac714d11a903c4152d5 (link)
#122330 bootstrap readme: fix, improve, update b7706a6fa2815e8c83b9d29baf1b56cf083add53 (link)

previous master: 65cd843ae0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6554a56): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.1%] 4
Improvements ✅
(secondary)
-0.8% [-1.2%, -0.4%] 13
All ❌✅ (primary) -1.2% [-1.2%, -1.1%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [2.8%, 3.3%] 2
Improvements ✅
(primary)
-2.0% [-3.1%, -0.1%] 4
Improvements ✅
(secondary)
-3.8% [-7.0%, -2.2%] 8
All ❌✅ (primary) -2.0% [-3.1%, -0.1%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.28s -> 669.92s (2.70%)
Artifact size: 309.94 MiB -> 309.97 MiB (0.01%)

@klensy
Copy link
Contributor

klensy commented Mar 12, 2024

Can #122320 be rerun here for perf?

@workingjubilee
Copy link
Member Author

I don't think we'll produce meaningfully different results, but why not:

@rust-timer build 2b188cc

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2b188cc): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.9%, -2.3%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.28s -> 651.81s (-0.07%)
Artifact size: 309.94 MiB -> 309.95 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.