Fix linting paths with qself in `unused_qualifications` #122038

Alexendoo · 2024-03-05T18:42:11Z

Fixes #121999

resolve_qpath ends up being called again with qself set to None to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already

rust/compiler/rustc_resolve/src/late.rs

Lines 4074 to 4088 in 96561a8

    
           // Make sure `A::B` in `<T as A>::B::C` is a trait item. 
        
           // 
        
           // Currently, `path` names the full item (`A::B::C`, in 
        
           // our example). so we extract the prefix of that that is 
        
           // the trait (the slice upto and including 
        
           // `qself.position`). And then we recursively resolve that, 
        
           // but with `qself` set to `None`. 
        
           let ns = if qself.position + 1 == path.len() { ns } else { TypeNS }; 
        
           let partial_res = self.smart_resolve_path_fragment( 
        
               &None, 
        
               &path[..=qself.position], 
        
               PathSource::TraitItem(ns), 
        
               Finalize::with_root_span(finalize.node_id, finalize.path_span, qself.path_span), 
        
               RecordPartialRes::No, 
        
           );

r? @petrochenkov

petrochenkov · 2024-03-05T20:56:10Z

@bors r+

bors · 2024-03-05T20:56:12Z

📌 Commit 6120de9 has been approved by petrochenkov

It is now in the queue for this repository.

…=petrochenkov Fix linting paths with qself in `unused_qualifications` Fixes rust-lang#121999 `resolve_qpath` ends up being called again with `qself` set to `None` to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already https://github.com/rust-lang/rust/blob/96561a8fd134e8f2b205769a4fca03b392d9f484/compiler/rustc_resolve/src/late.rs#L4074-L4088 r? `@petrochenkov`

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#113518 (bootstrap/libtest: print test name eagerly on failure even with `verbose-tests=false` / `--quiet`) - rust-lang#119888 (Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute) - rust-lang#121752 (Detect unused struct impls pub trait) - rust-lang#121885 (Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.) - rust-lang#121926 (`f16` and `f128` step 3: compiler support & feature gate) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#122015 (Add better explanation for `rustc_index::IndexVec`) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122038 (Fix linting paths with qself in `unused_qualifications`) r? `@ghost` `@rustbot` modify labels: rollup

…=petrochenkov Fix linting paths with qself in `unused_qualifications` Fixes rust-lang#121999 `resolve_qpath` ends up being called again with `qself` set to `None` to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already https://github.com/rust-lang/rust/blob/96561a8fd134e8f2b205769a4fca03b392d9f484/compiler/rustc_resolve/src/late.rs#L4074-L4088 r? ``@petrochenkov``

…=petrochenkov Fix linting paths with qself in `unused_qualifications` Fixes rust-lang#121999 `resolve_qpath` ends up being called again with `qself` set to `None` to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already https://github.com/rust-lang/rust/blob/96561a8fd134e8f2b205769a4fca03b392d9f484/compiler/rustc_resolve/src/late.rs#L4074-L4088 r? ```@petrochenkov```

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113518 (bootstrap/libtest: print test name eagerly on failure even with `verbose-tests=false` / `--quiet`) - rust-lang#119888 (Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute) - rust-lang#121089 (Remove `feed_local_def_id`) - rust-lang#121926 (`f16` and `f128` step 3: compiler support & feature gate) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#122015 (Add better explanation for `rustc_index::IndexVec`) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122038 (Fix linting paths with qself in `unused_qualifications`) r? `@ghost` `@rustbot` modify labels: rollup

…=petrochenkov Fix linting paths with qself in `unused_qualifications` Fixes rust-lang#121999 `resolve_qpath` ends up being called again with `qself` set to `None` to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already https://github.com/rust-lang/rust/blob/96561a8fd134e8f2b205769a4fca03b392d9f484/compiler/rustc_resolve/src/late.rs#L4074-L4088 r? ````@petrochenkov````

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113518 (bootstrap/libtest: print test name eagerly on failure even with `verbose-tests=false` / `--quiet`) - rust-lang#117199 (Change the documented implicit value of `-C instrument-coverage` to `=yes`) - rust-lang#121190 (avoid overlapping privacy suggestion for single nested imports) - rust-lang#121382 (Rework `untranslatable_diagnostic` lint) - rust-lang#121833 (Suggest correct path in include_bytes!) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#122038 (Fix linting paths with qself in `unused_qualifications`) - rust-lang#122051 (cleanup: remove zero-offset GEP) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#113518 (bootstrap/libtest: print test name eagerly on failure even with `verbose-tests=false` / `--quiet`) - rust-lang#117199 (Change the documented implicit value of `-C instrument-coverage` to `=yes`) - rust-lang#121190 (avoid overlapping privacy suggestion for single nested imports) - rust-lang#121382 (Rework `untranslatable_diagnostic` lint) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#122038 (Fix linting paths with qself in `unused_qualifications`) - rust-lang#122051 (cleanup: remove zero-offset GEP) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122038 - Alexendoo:unused-qualifications, r=petrochenkov Fix linting paths with qself in `unused_qualifications` Fixes rust-lang#121999 `resolve_qpath` ends up being called again with `qself` set to `None` to check trait items from fully qualified paths. To avoid this the lint is moved to a place that accounts for this already https://github.com/rust-lang/rust/blob/96561a8fd134e8f2b205769a4fca03b392d9f484/compiler/rustc_resolve/src/late.rs#L4074-L4088 r? `````@petrochenkov`````

Fix linting paths with qself in unused_qualifications

6120de9

rustbot assigned petrochenkov Mar 5, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2024

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 9 pull requests #122065

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 9 pull requests #122067

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 8 pull requests #122068

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 8 pull requests #122097

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 7 pull requests #122111

Merged

bors merged commit e93a3d1 into rust-lang:master Mar 6, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix linting paths with qself in `unused_qualifications` #122038

Fix linting paths with qself in `unused_qualifications` #122038

Alexendoo commented Mar 5, 2024

petrochenkov commented Mar 5, 2024

bors commented Mar 5, 2024

	// Make sure `A::B` in `<T as A>::B::C` is a trait item.
	//
	// Currently, `path` names the full item (`A::B::C`, in
	// our example). so we extract the prefix of that that is
	// the trait (the slice upto and including
	// `qself.position`). And then we recursively resolve that,
	// but with `qself` set to `None`.
	let ns = if qself.position + 1 == path.len() { ns } else { TypeNS };
	let partial_res = self.smart_resolve_path_fragment(
	&None,
	&path[..=qself.position],
	PathSource::TraitItem(ns),
	Finalize::with_root_span(finalize.node_id, finalize.path_span, qself.path_span),
	RecordPartialRes::No,
	);

Fix linting paths with qself in unused_qualifications #122038

Fix linting paths with qself in unused_qualifications #122038

Conversation

Alexendoo commented Mar 5, 2024

petrochenkov commented Mar 5, 2024

bors commented Mar 5, 2024

Fix linting paths with qself in `unused_qualifications` #122038

Fix linting paths with qself in `unused_qualifications` #122038