Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• Move some tests #121248 (Move some tests)
• Consider middle segments of paths in unused_qualifications #121528 (Consider middle segments of paths in unused_qualifications)
• Don't lint on executable crates with non_snake_case names #121749 (Don't lint on executable crates with non_snake_case names)
• library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr #121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr)
• Run some ui-fulldeps tests on stage 1 again #121945 (Run some ui-fulldeps tests on stage 1 again)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit e5a6d21 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit e5a6d21 with merge 3fb9000...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

SCRIPT=./x.py --stage 2 test --skip tests/ui --skip tests/rustdoc --skip tests/run-make-fulldeps
SELECT_XCODE=/Applications/Xcode_14.3.1.app
SHELL=/bin/bash
SHLVL=3
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.NxRyxmS5Cx/Listeners
STATS_EXTP=https://provjobdsettingscdn.blob.core.windows.net/settings/provjobdsettings-0.5.154/provjobd.data
STATS_RDCL=true
STATS_TIS=mining
STATS_TRP=true

[matthiaskrgr]

@bors retry
warning: spurious network error (2 tries remaining): [6] Couldn't resolve host name (Could not resolve host: index.crates.io)

[bors]

⌛ Testing commit e5a6d21 with merge 89b7830...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 89b7830 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#121248	Move some tests	176f251a3d3988f418816f67d7363d5efb92e2bf (link)
#121528	Consider middle segments of paths in unused_qualifications	f6ee0c0d7e340bf27eed847964571921caafed7c (link)
#121749	Don't lint on executable crates with non_snake_case names	cdb0b9aee0b3d705ad580a3b66bb122738653c08 (link)
#121935	library/ptr: mention that ptr::without_provenance is equiva…	cfb38919908ebc22b7d041275c9378b6293cb1d1 (link)
#121945	Run some ui-fulldeps tests on stage 1 again	7c81387458f1b94b2435e96eaacb696ed407299d (link)

previous master: 70aa0b86c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (89b7830): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 3.7%]	17
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-0.8%, 3.7%]	27

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.7%	[3.7%, 3.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.02s -> 643.72s (-0.05%)
Artifact size: 174.95 MiB -> 175.01 MiB (0.03%)

[Kobzol]

@rust-timer build f6ee0c0

[rust-timer]

Finished benchmarking commit (f6ee0c0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.3%, 2.6%]	14
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	11
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.8%, 2.6%]	25

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.6%	[-4.6%, -4.6%]	1
Improvements ✅ (secondary)	-2.4%	[-2.8%, -2.1%]	2
All ❌✅ (primary)	-4.6%	[-4.6%, -4.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 644.02s -> 643.036s (-0.15%)
Artifact size: 174.95 MiB -> 175.00 MiB (0.03%)

[Kobzol]

Looks like the regressions come from #121528. It seems to be a correctness fix, so I think it's fine, but just CCing @petrochenkov to check if this is expected.