-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add p=1
to weekly cargo update
#121923
Add p=1
to weekly cargo update
#121923
Conversation
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
doesn't that mean we also have to p=1 everything that conflicts with an automatic |
Well my reasoning was that while a regular PR author can just rebase, the bot won't until the next CI run a week later |
lol, so if there are merge conflicts or something else is broken, we just wait for another week? 😅 imo we should prioritize human-made prs since rebasing these requires a human to spend time, whereas remaking an automated |
The workflow can already be run manually (at least by some people, not sure by who). Could we make it auto-rebase an open PR, say, every hour? It seems to me that the purpose here is similar to dependabot: we want to always have an open PR with the latest set of changes in it, that's approved at some time after it's opened (and shouldn't be changed while approved) but otherwise is continuously kept up to date. |
Sounds reasonable. Maybe we can split this into 2 CI jobs, one to open a PR weekly and another to (hourly) rebase any currently-open PR? |
I'd still like to add rollup=never if the Homu PR lands 🤞🏻 |
…k-Simulacrum Bump `cargo update` PR more often r? `@Mark-Simulacrum` (rust-lang#121923 (comment))
Rollup merge of rust-lang#122489 - clubby789:more-cargo-update, r=Mark-Simulacrum Bump `cargo update` PR more often r? `@Mark-Simulacrum` (rust-lang#121923 (comment))
Since bumping dependencies tends to be very conflictly.
Blocked on rust-lang/homu#211 (if that takes a while this could just be a followup comment instead).