Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve do as a keyword #12170

Merged
merged 1 commit into from
Feb 11, 2014
Merged

Conversation

milibopp
Copy link
Contributor

This resolves issue #12157. Does that do it already or is there something else that needs taking care of?

As a side note, there seems to be some documentation, in which the old existence of the do keyword is explained. The list of keywords is not up-to-date either. But these are certainly separate issues.

Resolves issue rust-lang#12157. `do` is hereby reinstated as a keyword; no syntax is
associated with it though. Along the way, a unit test had to be adapted, since
it was using `do` as a method identifier.

Breaking changes:

- Any code using `do` as an identifier will no longer work.
@flaper87
Copy link
Contributor

👍 thanks!

@omasanori
Copy link
Contributor

👍

bors added a commit that referenced this pull request Feb 11, 2014
This resolves issue #12157. Does that do it already or is there something else that needs taking care of?  

As a side note, there seems to be some documentation, in which the old existence of the do keyword is explained. The list of keywords is not up-to-date either. But these are certainly separate issues.
@bors bors closed this Feb 11, 2014
@bors bors merged commit a2fab45 into rust-lang:master Feb 11, 2014
@milibopp milibopp deleted the feature/reserve_do_keyword branch February 11, 2014 10:36
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 25, 2024
…rding, r=llogiq

Improve wording for suggestion messages

Follow-up of rust-lang/rust-clippy#12140.

r? `@llogiq`

changelog: Improve wording for suggestion messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants