Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the extra directives for Mode::CoverageRun into iter_header #121233

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Move the extra directives for Mode::CoverageRun into iter_header #121233

merged 2 commits into from
Feb 20, 2024

Commits on Feb 17, 2024

  1. Wrap iter_header callback arguments in a documentable struct

    @Zalathar
    Zalathar committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    488ffaa View commit details
    Browse the repository at this point in the history

  2. Move the extra directives for Mode::CoverageRun into iter_header 

    When these extra directives were ported over as part of rust-lang#112300, it made sense
to introduce `iter_header_extra` and pass them in as an extra argument.

But now that rust-lang#120881 has added a `mode` parameter to `iter_header` for its own
purposes, it's slightly simpler to move the coverage special-case code directly
into `iter_header` as well. This lets us get rid of `iter_header_extra`.
    @Zalathar
    Zalathar committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    c521d7f View commit details
    Browse the repository at this point in the history