ICE when compiling this core change #121064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @dtolnay suggestion in serde-rs/serde#2697 (comment) - attempt to speed up performance in the cases of a simple string format without arguments: ```rust write!(f, "text") -> f.write_str("text") ```
rustbot
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@rustbot blocked |
rustbot
added
S-blocked
Noratrieb
reviewed
Feb 14, 2024
| @@ -201,13 +201,23 @@ pub trait Write { | |||
| impl<W: Write + ?Sized> SpecWriteFmt for &mut W { | |||
| #[inline] | |||
| default fn spec_write_fmt(mut self, args: Arguments<'_>) -> Result { | |||
| if unsafe { core::intrinsics::is_val_statically_known(args) } { | |||
There was a problem hiding this comment.
is_val_statically_known only supports primitives
There was a problem hiding this comment.
feel free to PR a better error message, since I'd expect many people to run into this
There was a problem hiding this comment.
@Nilstrieb I suspect ICE is ICE no matter what the users try to do? That said, I don't see anything in the docs about it only supporting primitives - it does have T: Copy though.
There was a problem hiding this comment.
it's not documented, you need to look at the implementation
There was a problem hiding this comment.
Can an expression be evaluated for this intrinsic? e.g. for a primitive bool:
Suggested change
| if unsafe { core::intrinsics::is_val_statically_known(args) } { | |
| if unsafe { core::intrinsics::is_val_statically_known(args.as_str().is_some()) } { |
There was a problem hiding this comment.
I suspect ICE is ICE no matter what the users try to do?
No, if you use internal features such as intrinsics, then some ICEs are expected. It's not worth the effort and overhead of guarding against ICEs when users explicitly ask to fiddle with the internal details of the compiler.
This was referenced Feb 14, 2024
|
ICEing was fixed in #120484. Best thing to do here is probably to update the docs to make it better, unless we want to backport the fix? |
|
I don't think we want to backport this. The docs could be made better |
|
For the novice, when you say backport - are you referring to the fact that the current binary bootstrapping compiler used by |
|
backporting means taking a commit that landed on nightly and letting it skip the release train by putting it directly into beta or even stable. We do this for urgent issues like bad regression fixes. |
|
Going to close this PR. We get a better error message on nightly, which seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug report for this PR: #121066
This code causes ICE in rustc when running
./x.py build --stage 1 alloc-- the error shows up in CI https://github.com/rust-lang/rust/actions/runs/7896056798/job/21549391196?pr=121064#step:26:2201This issue showed up with two code variants:
Stacktrace