Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove good path delayed bugs #120959

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Remove good path delayed bugs #120959

merged 2 commits into from
Feb 13, 2024

Commits on Feb 12, 2024

  1. Remove TypeErrCtxt::drop. 

    The check within changed from `delay_span_bug` to `delay_good_path_bug`
in rust-lang#110476, and removing the check altogether was considered. It's a
very weak sanity check and gets in the way of removing good path delayed
bugs altogether, so this PR just removes it.
    @nnethercote
    nnethercote committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    173dbc9 View commit details
    Browse the repository at this point in the history

  2. Remove good_path_delayed_bug. 

    It's only has a single remaining purpose: to ensure that a diagnostic is
printed when `trimmed_def_paths` is used. It's an annoying mechanism:
weak, with odd semantics, badly named, and gets in the way of other
changes.

This commit replaces it with a simpler `must_produce_diag` mechanism,
getting rid of a diagnostic `Level` along the way.
    @nnethercote
    nnethercote committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9f2aa09 View commit details
    Browse the repository at this point in the history