Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::thread::available_parallelism merging linux/android/freebsd version #120589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std::thread::available_parallelism merging linux/android/freebsd version #120589

wants to merge 1 commit into from
+11 −22

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Feb 2, 2024

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2024

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 2, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@m-ou-se
Copy link
Member

m-ou-se commented Feb 8, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Feb 8, 2024

📌 Commit 0bfcafd has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024
@Nadrieril
Copy link
Member

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
ee7081c 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 8, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
9fd0a0b 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 8, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
8038608 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 8, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
4f3d9e0 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2024
@bors
Auto merge of rust-lang#120800 - matthiaskrgr:rollup-9vqhh6q, r=matth…
da3f4c5 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#113026 (Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120590 (Remove unused args from functions)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120693 (Invert diagnostic lints.)
 - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`)
 - rust-lang#120750 (No need to take `ImplTraitContext` by ref)
 - rust-lang#120765 (Reorder diagnostics API)
 - rust-lang#120772 (Remove myself from review rotation.)
 - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)

Failed merges:

 - rust-lang#120782 (Fix mir pass ICE in the presence of other errors)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
2bb518e 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2024
@bors
Auto merge of rust-lang#120824 - matthiaskrgr:rollup-orc6q7n, r=matth…
31bdbfd 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120308 (core/time: avoid divisions in Duration::new)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120672 (std::thread update freebsd stack guard handling.)
 - rust-lang#120693 (Invert diagnostic lints.)
 - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`)
 - rust-lang#120806 (Clippy subtree update)
 - rust-lang#120809 (Use `transmute_unchecked` in `NonZero::new`.)
 - rust-lang#120817 (Fix more `ty::Error` ICEs in MIR passes)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120589 - devnexen:cpuaff_fbsd_upd, r=m-ou-se
a4c5094 
std::thread::available_parallelism merging linux/android/freebsd version

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2024
@bors
Auto merge of rust-lang#120861 - matthiaskrgr:rollup-pkbbh0r, r=matth…
036b1d1 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120584 (For a rigid projection, recursively look at the self type's item bounds to fix the `associated_type_bounds` feature)
 - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
 - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
 - rust-lang#120629 (Move some test files)
 - rust-lang#120846 (Update jobserver-rs to 0.1.28)
 - rust-lang#120850 (ast_lowering: Fix regression in `use ::{}` imports.)
 - rust-lang#120853 (Avoid a collection and iteration on empty passes)

Failed merges:

 - rust-lang#120549 (modify alias-relate to also normalize ambiguous opaques)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r- rollup=never
linking failure
#120861 (comment)

@workingjubilee
Copy link
Member

@devnexen Is this blocked?

@devnexen
Copy link
Contributor Author

devnexen commented Apr 1, 2024

yes this PR needs to go first.

@workingjubilee workingjubilee added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2024
devnexen added a commit to devnexen/rust that referenced this pull request Apr 28, 2024
@devnexen
ci update freebsd version proposal, freebsd 12 being eol.
c01b042 
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.
@bors
Copy link
Contributor

bors commented May 1, 2024

☔ The latest upstream changes (presumably #124491) made this pull request unmergeable. Please resolve the merge conflicts.

devnexen added a commit to devnexen/rust that referenced this pull request May 5, 2024
@devnexen
ci update freebsd version proposal, freebsd 12 being eol.
9cacc40 
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.
@devnexen devnexen mentioned this pull request May 5, 2024
Merged
@workingjubilee workingjubilee added O-linux Operating system: Linux O-android Operating system: Android O-freebsd Operating system: FreeBSD labels Jul 14, 2024
devnexen added a commit to devnexen/rust that referenced this pull request Jul 27, 2024
@devnexen
ci update freebsd version proposal, freebsd 12 being eol.
4b98f99 
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.
devnexen added a commit to devnexen/rust that referenced this pull request Sep 28, 2024
@devnexen
ci update freebsd version proposal, freebsd 12 being eol.
1239c81 
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2024
@bors
Auto merge of rust-lang#120869 - devnexen:update_fbsd_ci, r=Mark-Simu…
fb32dd4 
…lacrum

ci update freebsd version proposal, freebsd 12 being eol

raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

Blocked on rust-lang#130465
@devnexen
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 21, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 22, 2024
@bors
Auto merge of #120869 - devnexen:update_fbsd_ci, r=Mark-Simulacrum
ce8da11 
ci update freebsd version proposal, freebsd 12 being eol

raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang/rust#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

Blocked on rust-lang/rust#130465
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Oct 22, 2024
@bors
Auto merge of #120869 - devnexen:update_fbsd_ci, r=Mark-Simulacrum
bf1f483 
ci update freebsd version proposal, freebsd 12 being eol

raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang/rust#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

Blocked on rust-lang/rust#130465
@tgross35
Copy link
Contributor

That PR was reverted in #132228, so I believe this is blocked on the same thing again.

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2024
devnexen added a commit to devnexen/rust that referenced this pull request Jan 4, 2025
@devnexen
ci update freebsd version proposal, freebsd 12 being eol.
1fec91a 
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

TBD: updating path for 13.3 binaries in src/ci/docker/scripts/freebsd-toolchain.sh
@devnexen devnexen mentioned this pull request Jan 4, 2025
Closed
@devnexen
std::thread::available_parallelism merging linux/android/freebsd version
6f9f448 
FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer
with Linux. 13.0 and even 13.1 being EOL, we can simplify here.
@devnexen
Copy link
Contributor Author

Giving another try since #132232 is merged

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

Assignees

@m-ou-se m-ou-se

Labels
O-android Operating system: Android O-freebsd Operating system: FreeBSD O-linux Operating system: Linux O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@devnexen @rustbot @rust-log-analyzer @m-ou-se @bors @Nadrieril @matthiaskrgr @workingjubilee @tgross35 @the8472