-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bound errors span label cleanup #120400
Bound errors span label cleanup #120400
Changes from 1 commit
3691ab8
757b726
7df4a09
fc964fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,11 +21,7 @@ error[E0599]: the method `count` exists for struct `Filter<Fuse<Once<&str>>, {cl | |
LL | once::<&str>("str").fuse().filter(|a: &str| true).count(); | ||
| --------- ^^^^^ method cannot be called due to unsatisfied trait bounds | ||
| | | ||
| doesn't satisfy `<_ as FnOnce<(&&str,)>>::Output = bool` | ||
| doesn't satisfy `_: FnMut<(&&str,)>` | ||
--> $SRC_DIR/core/src/iter/adapters/filter.rs:LL:COL | ||
| | ||
= note: doesn't satisfy `_: Iterator` | ||
| doesn't satisfy `<_ as FnOnce<(&&str,)>>::Output = bool` or `_: FnMut<(&&str,)>` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't really an improvement imo. The vertical list is easier to read There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the real issue here is that we need to special case closure trait mismatches to talk in terms that are clearer, instead of just "list of bounds" like we do here. |
||
| | ||
= note: the following trait bounds were not satisfied: | ||
`<{closure@$DIR/issue-36053-2.rs:7:39: 7:48} as FnOnce<(&&str,)>>::Output = bool` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have a single "
NoDerives
does not implementEq
,Ord
,PartialEq
andPartialOrd
" for when it's just a bunch of trait boundsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather we did that as part of its own PR to make reviewing easier :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea makes sense