Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable M1 runners on GitHub Actions #119546

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Temporarily disable M1 runners on GitHub Actions #119546

merged 1 commit into from
Jan 3, 2024

Conversation

jdno
Copy link
Member

@jdno jdno commented Jan 3, 2024

This commit temporarily reverts the addition of M1 runners on GitHub Actions to work around a billing issue related to their beta.

The runners for dist-aarch64-apple were originally changed in 821b03d, and the aarch64-apple job was added in 6909992.

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2024

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 3, 2024
@jdno
Copy link
Member Author

jdno commented Jan 3, 2024

I forgot to expand the YAML anchors. One second...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdno jdno force-pushed the temporarily-disable-m1-runners branch from bb0851e to ea34c47 Compare January 3, 2024 14:14
@Kobzol
Copy link
Contributor

Kobzol commented Jan 3, 2024

Maybe we should just disable aarch64-apple, given that it was only enabled very recently (~2 months ago), and we're not sure if this modified configuration will work for it? But in any case, r=me, so that the tree can open ASAP.

@jdno
Copy link
Member Author

jdno commented Jan 3, 2024

That's a good idea. Since this is only temporary, we should be fine skipping the tests for the moment.

@jdno
Temporarily disable M1 runners on GitHub Actions
0f9844d 
This commit temporarily reverts the addition of M1 runners on GitHub
Actions to work around a billing issue related to their beta. It also
removes the `aarch64-apple` job, which was only added after the addition
of M1 runners. Since it has never been tested on the prior hardware, we
are skipping the tests to reduce the risk of build failures.
@jdno jdno force-pushed the temporarily-disable-m1-runners branch from ea34c47 to 0f9844d Compare January 3, 2024 14:21
@Kobzol
Copy link
Contributor

Kobzol commented Jan 3, 2024

@bors r+ rollup=never p=999

Let's see if this works.

@bors
Copy link
Contributor

bors commented Jan 3, 2024

📌 Commit 0f9844d has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 3, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2024
@bors
Copy link
Contributor

bors commented Jan 3, 2024

⌛ Testing commit 0f9844d with merge 2e79c8d...

@fmease fmease mentioned this pull request Jan 3, 2024
Merged
@bors
Copy link
Contributor

bors commented Jan 3, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 2e79c8d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2024
@bors bors merged commit 2e79c8d into rust-lang:master Jan 3, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 3, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2e79c8d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.95s -> 668.218s (0.19%)
Artifact size: 311.74 MiB -> 311.73 MiB (-0.00%)

@dtolnay dtolnay mentioned this pull request Jan 4, 2024
Closed
This was referenced Jan 6, 2024
Closed
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 7, 2024
Merged
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 7, 2024
@Mark-Simulacrum Mark-Simulacrum removed this from the 1.77.0 milestone Jan 7, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.76.0 milestone Jan 7, 2024
@Mark-Simulacrum
Copy link
Member

I've backported this to beta in #119719, we can revert that if this is fixed prior to the release.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
@bors
Auto merge of rust-lang#119719 - Mark-Simulacrum:beta-next, r=Mark-Si…
d05dd84 
…mulacrum

[beta] backport rollup

This PR backports:

- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo

And also:

- Bumps stage0 to released stable.

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2024
@bors
Auto merge of rust-lang#119719 - Mark-Simulacrum:beta-next, r=Mark-Si…
650745c 
…mulacrum

[beta] backport rollup

This PR backports:

- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo

And also:

- Bumps stage0 to released stable.

r? `@Mark-Simulacrum`
@jdno jdno deleted the temporarily-disable-m1-runners branch January 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jdno @rustbot @rust-log-analyzer @Kobzol @bors @rust-timer @Mark-Simulacrum